[issue6623] Lib/ftplib.py Netrc class should be removed.

Berker Peksag added the comment: Thanks for the patch, Matt. Have you signed a contributor's agreement? You can find it at https://www.python.org/psf/contrib/contrib-form/ -- assignee: -> berker.peksag priority: release blocker -> normal resolution: -> fixed stage: patch review -> res

[issue6623] Lib/ftplib.py Netrc class should be removed.

Roundup Robot added the comment: New changeset ec196a99af8d by Berker Peksag in branch 'default': Issue #6623: Remove deprecated Netrc class in the ftplib module. https://hg.python.org/cpython/rev/ec196a99af8d -- ___ Python tracker

[issue6623] Lib/ftplib.py Netrc class should be removed.

Berker Peksag added the comment: Here's a patch with a whatsnew entry. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file36807/issue6623.diff ___ Python tracker ___

[issue6623] Lib/ftplib.py Netrc class should be removed.

R. David Murray added the comment: Great. The patch looks good to me, too. Can someone add a What's New removal entry to the patch? (See the 3.4 What's New for a model of what removals look like in What's New.) (It would also be nice if the patch were in hg format so that we get a 'review'

[issue6623] Lib/ftplib.py Netrc class should be removed.

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue6623] Lib/ftplib.py Netrc class should be removed.

Francis MB added the comment: I've downloaded 'remove_Netrc_class2.patch' and passes the test suite, the examples on the documentation run ok and manually from the command line: $hg tip changeset: 92597:e29866cb6b98 tag: tip parent: 92594:d43d4d4ebf2c parent: 92596:54987723d

[issue6623] Lib/ftplib.py Netrc class should be removed.

R. David Murray added the comment: Did you hand test it? Also, you could open a new issue to add tests for the ftplib cli, and probably improve and document it? It was designed as a test, but some people may be using it and it might even be actually useful :) --

[issue6623] Lib/ftplib.py Netrc class should be removed.

Matt Chaput added the comment: This patch is the same as my previous one, except instead of removing Netrc usage from the ftplib.test() function, it replaces it with the netrc.netrc object. Note that there are no existing tests for the ftplib.test() function. Also did some very minor cleanups

[issue6623] Lib/ftplib.py Netrc class should be removed.

R. David Murray added the comment: This looks good, except that if we are not going to delete that test routine (and we aren't because we didn't deprecate it :) I think we should instead replace the usage of Netrc with the netrc module. -- ___ Pytho

[issue6623] Lib/ftplib.py Netrc class should be removed.

Matt Chaput added the comment: Created patch to remove the Netrc class and its unit tests (for Python 3.5). -- nosy: +maatt Added file: http://bugs.python.org/file34806/remove_Netrc_class.patch ___ Python tracker __

[issue6623] Lib/ftplib.py Netrc class should be removed.

R. David Murray added the comment: Thanks for the report. ftplib.Netrc has been deprecated (via its doc string) since at least Python 2.4, and is no longer documented in the library reference. I've added an explicit DeprecationWarning in Python 3.4, and have altered this issue to call for it

[issue6623] Lib/ftplib.py netrc class parsing problem

Roundup Robot added the comment: New changeset acf247d25f17 by R David Murray in branch 'default': #6623: Add explicit deprecation warning for ftplib.Netrc. http://hg.python.org/cpython/rev/acf247d25f17 -- nosy: +python-dev ___ Python tracker

[issue6623] Lib/ftplib.py netrc class parsing problem

Vincent Legoll added the comment: If the macro_lines is not emptied upon end of parsing a macro definition, if there's another macro definiton it will 'inherit' the lines from the previous one, which could very well be uncool. The use before definition should also be fixed. Please advise if a

[issue6623] Lib/ftplib.py netrc class parsing problem

New submission from Vincent Legoll : The 'macro_lines' list should probably be emptied upon leaving macro parsing mode. Simplify code by using the 'macro_name' variable as the boolean for macro parsing mode. Deprecated code probably should be fixed until completely removed -- keywords:

[issue6623] Lib/ftplib.py

Changes by Vincent Legoll : -- components: Library (Lib) nosy: vincele severity: normal status: open title: Lib/ftplib.py versions: Python 3.2 ___ Python tracker ___ _