[issue6582] test_telnetlib doesn't test Telnet.write

Rodrigo Steinmuller Wanderley added the comment: On Thu, 03 Sep 2009 20:38:49 + Jack Diederich wrote: > > Jack Diederich added the comment: > > applied in r74638 > and I've added you to Misc/ACKS > Thanks again for the patch! No problem, Anything I can do to improve telnetlib further?

[issue6582] test_telnetlib doesn't test Telnet.write

Jack Diederich added the comment: applied in r74638 and I've added you to Misc/ACKS Thanks again for the patch! -- resolution: -> accepted status: open -> closed ___ Python tracker

[issue6582] test_telnetlib doesn't test Telnet.write

Jack Diederich added the comment: Thanks Rodrigo, I'll integrate this and check it in. -- ___ Python tracker ___ ___ Python-bugs-list

[issue6582] test_telnetlib doesn't test Telnet.write

Changes by Rodrigo Steinmuller Wanderley : Added file: http://bugs.python.org/file14686/telnetlib_writetest.diff ___ Python tracker ___ ___ Pyt

[issue6582] test_telnetlib doesn't test Telnet.write

Changes by Rodrigo Steinmuller Wanderley : Removed file: http://bugs.python.org/file14668/write_test.patch ___ Python tracker ___ ___ Python-bu

[issue6582] test_telnetlib doesn't test Telnet.write

Rodrigo Steinmuller Wanderley added the comment: Did only minor modifications to TelnetSocketSendall class. Please review the following patch. -- keywords: +patch nosy: +rwanderley Added file: http://bugs.python.org/file14668/write_test.patch ___ Py

[issue6582] test_telnetlib doesn't test Telnet.write

Jack Diederich added the comment: Marking as easy. What needs to be done is to add a small fake socket class that redefines socket.sendall(self, bytes) to capture the args to sock.sendall so it can be assertEqual'd to the expected bytes. class SocketSendall(socket.socket): _raw_sent = b''

[issue6582] test_telnetlib doesn't test Telnet.write

New submission from Jack Diederich : test/test_telnetlib.py has zero tests for the telnetlib.Telnet.write method. -- assignee: jackdied messages: 90963 nosy: jackdied severity: normal status: open title: test_telnetlib doesn't test Telnet.write versions: Python 2.7, Python 3.2 _