[issue6484] No unit test for mailcap module

R. David Murray added the comment: There are divided opinions about the advisability of backporting tests that are not part of a bug fix. In this case, there is also the fact that it includes a test that fails without a bug fix that was not backported. --

[issue6484] No unit test for mailcap module

Petri Lehtinen added the comment: Any reason why this hasn't been backported to 3.2 or 2.7? -- nosy: +petri.lehtinen ___ Python tracker ___ ___

[issue6484] No unit test for mailcap module

Nick Coghlan added the comment: Ah, cheers - closing this one again. /me wanders off to meta-tracker to ask for a list of "dependency of" and "superseder of" issues in the issue header... -- status: open -> closed ___ Python tracker

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: There's a bug for that test failure: #9923. I submitted a patch with it. Committing that should fix the failure. -- ___ Python tracker ___ __

[issue6484] No unit test for mailcap module

Nick Coghlan added the comment: The buildbots are reporting a test failure on Windows: == FAIL: test_listmailcapfiles (test.test_mailcap.HelperFunctionTest) --

[issue6484] No unit test for mailcap module

Roundup Robot added the comment: New changeset a1bb07d67a24 by Ezio Melotti in branch 'default': #6484: refactor a bit the tests. http://hg.python.org/cpython/rev/a1bb07d67a24 -- ___ Python tracker

[issue6484] No unit test for mailcap module

Roundup Robot added the comment: New changeset 69cb66ab61cc by Nick Coghlan in branch 'default': Add unit tests for the mailcap module. Patch by Gregory Nofi (closes #6484) http://hg.python.org/cpython/rev/69cb66ab61cc -- nosy: +python-dev resolution: -> fixed stage: patch review -> co

[issue6484] No unit test for mailcap module

Anthony Briggs added the comment: Added ncoghlan to the nosy list - we're reviewing/fixing unit test coverage as part of the sprints at PyconAU. Thanks Gnofi! -- ___ Python tracker

[issue6484] No unit test for mailcap module

Changes by Anthony Briggs : -- nosy: +anthonyb, ncoghlan versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Added file: http://bugs.python.org/file19127/test_mailcap.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: r.david.murray: Thanks a lot for your feedback! I've implemented those suggestions and they helped located a bug. (See case 9923.) -- Added file: http://bugs.python.org/file19126/test_mailcap.py ___ Python tracker

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Removed file: http://bugs.python.org/file17042/test_mailcap.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Removed file: http://bugs.python.org/file15752/test_mailcap.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: Replacing .mailcap with mailcap.txt. Same content, but with more conventional file name. -- Added file: http://bugs.python.org/file19125/mailcap.txt ___ Python tracker _

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Removed file: http://bugs.python.org/file15753/.mailcap ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue6484] No unit test for mailcap module

R. David Murray added the comment: Thanks for contributing this; sorry it took so long to get a review. Overall the tests look good (I didn't work through the logic of each test that looks up data; I'm trusting you on that part :) Here are some comments: 1) In test_listmailcapfiles, you can

[issue6484] No unit test for mailcap module

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue6484] No unit test for mailcap module

Changes by Antoine Pitrou : -- nosy: +ezio.melotti priority: low -> normal stage: unit test needed -> patch review versions: -Python 2.7 ___ Python tracker ___ __

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Removed file: http://bugs.python.org/file17041/test_mailcap.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue6484] No unit test for mailcap module

Changes by Gregory Nofi : Added file: http://bugs.python.org/file17042/test_mailcap.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: Submitting Python 3 version of test. Note that it currently fails due to Issue8496. It should use the same .mailcap file I submitted earlier. -- Added file: http://bugs.python.org/file17041/test_mailcap.py ___ Python

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: This is a sample .mailcap I created for the test. It should also go in the Lib/test directory. It begins with a period due to a mailcap file naming convention (see RFC 1524). Is it OK that the file will be semi-hidden? -- Added file: http://bugs.python

[issue6484] No unit test for mailcap module

Gregory Nofi added the comment: Attached is a new file for testing the mailcap module in Python 2.7. Writing the test was a little tricky because the existence and contents of the .mailcap file(s) will vary depending on the system or user. Therefore, the test mostly uses its own version of .m

[issue6484] No unit test for mailcap module

Martin v. Löwis added the comment: Please also identify yourself with your full name. -- nosy: +loewis ___ Python tracker ___ ___ Pyth

[issue6484] No unit test for mailcap module

R. David Murray added the comment: Welcome! Please read the material at http://www.python.org/dev if you haven't already, especially the dev FAQ. At the moment the case can't be assigned to you in the tracker interface, but your claiming it in the text is sufficient. Please write the tests an

[issue6484] No unit test for mailcap module

New submission from Greg : There is currently no test_mailcap or any other standalone unit test for the mailcap module. The only existing test is a self-test at the end of the module. I would like to be assigned to work on this patch. (Why am I assigning myself to write tests for a small, older