[issue6482] PATCH: tiny simplification for subprocess

Georg Brandl added the comment: Very true. Since there was no indication that the previous version was faulty, reverted in r74029. -- ___ Python tracker ___ _

[issue6482] PATCH: tiny simplification for subprocess

David Goodger added the comment: To clarify my last message: the log message for r74028 ('simplify "except: raise" to "finally:"') implies a nonexistent equivalence. So was the log message in error, or the change itself? -- ___ Python tracker

[issue6482] PATCH: tiny simplification for subprocess

David Goodger added the comment: r74028 changes the logic of the code. The "finally" clause always executes, regardless of whether or not an exception was raised. The previous behavior only executed when there was an exception. I don't know if the previous logic was correct, or the new logic,

[issue6482] PATCH: tiny simplification for subprocess

New submission from Georg Brandl : Thanks, committed in r74028. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed ___ Python tracker ___ _

[issue6482] PATCH: tiny simplification for subprocess

Changes by Yinon Ehrlich : -- files: subprocess.patch keywords: patch nosy: Yinon severity: normal status: open title: PATCH: tiny simplification for subprocess versions: Python 2.7 Added file: http://bugs.python.org/file14499/subprocess.patch ___ Pyt