[issue6478] time.tzset does not reset _strptime's locale time cache

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: Thanks Serhiy. Can we close this now? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue6478] time.tzset does not reset _strptime's locale time cache

Roundup Robot added the comment: New changeset 2ae5c51c5dea by Serhiy Storchaka in branch '2.7': Issue #6478: _strptime's regexp cache now is reset after changing timezone https://hg.python.org/cpython/rev/2ae5c51c5dea New changeset 4b0a4da1aa27 by Serhiy Storchaka in branch '3.4': Issue #6478:

[issue6478] time.tzset does not reset _strptime's locale time cache

Serhiy Storchaka added the comment: I forgot about this issue and proposed similar patch for issue25168. It doesn't recalculate timezone values (a tuple of frozensets) on every _strptime call, but uses cheaper tests for time.tzname and time.daylight. issue6478_v3.diff has a bug, it doesn't cle

[issue6478] time.tzset does not reset _strptime's locale time cache

R. David Murray added the comment: Berker: the patch doesn't apply cleanly any more. Also, about the test_bad_timezone modification...what about the previous check that the tzname wasn't in UTC/GMT? Isn't that still needed? Or perhaps better yet, an additional @run_with_tz decorator? (Note

[issue6478] time.tzset does not reset _strptime's locale time cache

Serhiy Storchaka added the comment: May be System Z Linux buildbot fails due to this bug (http://buildbot.python.org/all/builders/System%20Z%20Linux%203.x/builds/1154/steps/test/logs/stdio): == ERROR: test_strptime (test.dateti

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: > There is a long line in _strptime.py which I will fix before > committing. Ops, fixed. Also, I've found a better place for the test in Lib/test/test_strptime.py and moved it to the test_strptime.CacheTests. When I applied the patch, test_bad_timezone test fai

[issue6478] time.tzset does not reset _strptime's locale time cache

Alexander Belopolsky added the comment: issue6478_v2.patch looks good to me. There is a long line in _strptime.py which I will fix before committing. -- stage: test needed -> commit review versions: -Python 3.2 ___ Python tracker

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: Alexander: Did you have a chance to review the test? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: > 2. Please use @run_with_tz decorator. Done. Patch attached. -- Added file: http://bugs.python.org/file27749/issue6478_v2.patch ___ Python tracker _

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: Thanks for the review. > 1. Does it work on Windows? It seems to rely on Olson's TZ names. Is `time.tzset()` function only available on Unix? See: http://docs.python.org/dev/library/time.html#time.tzset > 2. Please use @run_with_tz decorator. I will update m

[issue6478] time.tzset does not reset _strptime's locale time cache

Alexander Belopolsky added the comment: The patch looks good, but I have a few comments on the test: 1. Does it work on Windows? It seems to rely on Olson's TZ names. 2. Please use @run_with_tz decorator. -- ___ Python tracker

[issue6478] time.tzset does not reset _strptime's locale time cache

Berker Peksag added the comment: Here is the second patch with Alexander Belopolsky's comments addressed. -- nosy: +berker.peksag versions: +Python 3.3, Python 3.4 -Python 3.1 Added file: http://bugs.python.org/file27732/issue6478.patch ___ Python tra

[issue6478] time.tzset does not reset _strptime's locale time cache

Alexander Belopolsky added the comment: Thank you for the bug report and a patch. This does look like a bug and proposed patch seems to be the simplest way to fix it. It is unfortunate that the entire TimeRE cache needs to be recalculated when only 'Z' entry is invalidated by TZ change. Ple

[issue6478] time.tzset does not reset _strptime's locale time cache

Changes by Alexander Belopolsky : -- assignee: -> belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue6478] time.tzset does not reset _strptime's locale time cache

Mihai Ibanescu added the comment: Proposed patch attached. -- keywords: +patch Added file: http://bugs.python.org/file17964/_strptime.py.patch ___ Python tracker ___

[issue6478] time.tzset does not reset _strptime's locale time cache

Changes by Mark Lawrence : -- nosy: +belopolsky stage: -> needs patch versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.4, Python 2.6 ___ Python tracker ___ ___

[issue6478] time.tzset does not reset _strptime's locale time cache

New submission from Mihai Ibanescu : If one changes from one timezone to another within the same python process, and if one tries to parse a time string that includes the timezone, the library malfunctions. See attached script for a reproducer. The problem is that, even though time.tzset() is c