[issue6243] getkey() can segfault in combination with curses.ungetch()

A.M. Kuchling added the comment: Backported to 2.6-maint in commit 78324. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue6243] getkey() can segfault in combination with curses.ungetch()

A.M. Kuchling added the comment: Thanks for the bug report and for the fix; committed to trunk in rev. 75066. I modified the patch slightly to declare the 'knp' variable in the 'else' block, and both the unctrl()/keyname() sections use the variable. -- ___

[issue6243] getkey() can segfault in combination with curses.ungetch()

Georg Brandl added the comment: Andrew - do you still feel responsible for curses? -- assignee: -> akuchling nosy: +akuchling, georg.brandl ___ Python tracker ___ __

[issue6243] getkey() can segfault in combination with curses.ungetch()

Jerry Chen added the comment: Another patch for the same code change but against the 3.1 branch. -- versions: +Python 3.0, Python 3.1 Added file: http://bugs.python.org/file14364/issue6243-py3.1-cursesmodule.diff ___ Python tracker

[issue6243] getkey() can segfault in combination with curses.ungetch()

Jerry Chen added the comment: Sorry -- bad patch, uploading correct one. -- Added file: http://bugs.python.org/file14363/issue6243-py2.7-cursesmodule.diff ___ Python tracker ___

[issue6243] getkey() can segfault in combination with curses.ungetch()

Changes by Jerry Chen : Removed file: http://bugs.python.org/file14362/issue6243-py2.7-cursesmodule.diff ___ Python tracker ___ ___ Python-bugs

[issue6243] getkey() can segfault in combination with curses.ungetch()

Jerry Chen added the comment: Trundle's original patch against r73301 still works currently, but I made a minor tweak and rediff'd. The attached patch is against 2.7 - r73552. I added knp usage to the NetBSD #ifdef region so a) the compiler doesn't complain about unused 'knp' on NetBSD and b)

[issue6243] getkey() can segfault in combination with curses.ungetch()

Jerry Chen added the comment: Verified Bus Error with code snippet in python 2.7 and 3.1 trunks r73552, e.g.: (gdb) where #0 0x925f6f30 in strlen () #1 0x0005ea10 in PyString_FromString (str=0x0) at Objects/stringobject.c:125 #2 0x003c1710 in PyCursesWindow_GetKey (self=0x3320f0, args=0x3000

[issue6243] getkey() can segfault in combination with curses.ungetch()

Changes by Sebastian Ramacher : -- nosy: +sebastinas ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue6243] getkey() can segfault in combination with curses.ungetch()

New submission from Trundle : Snippet to reproduce: import curses scr = curses.initscr() curses.ungetch(1025) scr.getkey() This is because `keyname()` in `PyCursesWindow_GetKey()` returns NULL which is passed to `PyString_FromString()` then. The attached patch fixes the segfault. --