[issue6151] Make PyDescr_COMMON conform to standard C

Alexandre Vassalotti added the comment: Committed in r74159 (branches/py3k). -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue6151] Make PyDescr_COMMON conform to standard C

Alexandre Vassalotti added the comment: > I'm not sure what the "new patch" is since you haven't uploaded it Oh silly me. Here's the new patch. -- Added file: http://bugs.python.org/file14459/strict-aliasing-pydescr-2.diff ___ Python tracker

[issue6151] Make PyDescr_COMMON conform to standard C

Antoine Pitrou added the comment: I'm not sure what the "new patch" is since you haven't uploaded it, but the original patch looks ok. In any case, it shouldn't go into 3.1 since it breaks source-level compatibility. -- nosy: +pitrou versions: -Python 3.1 _

[issue6151] Make PyDescr_COMMON conform to standard C

Alexandre Vassalotti added the comment: New patch with the superfluous macros stripped out. However, I still like my original patch better, since it is a bit more consistent. Anyway, is anyone opposed to this change? -- ___ Python tracker

[issue6151] Make PyDescr_COMMON conform to standard C

Martin v. Löwis added the comment: The patch looks fine in principle. I believe many of the macro applications are unnecessary, because the type of the variables being accessed is already PyDescrObject. Not sure whether this can be applied to 3.1 still. --

[issue6151] Make PyDescr_COMMON conform to standard C

New submission from Alexandre Vassalotti : PyDescrObject make use of the some undefined behavior noted in PEP 3123 for PyObject in Python 2.x. Although fixing this requires breaking backward-compatibility, this shouldn't be much a problem since PyDescrObject is only used directly by Python itself