[issue6032] Fix refleaks in test_urllib2_localnet

Collin Winter added the comment: Applied as r72777 (trunk), r72778 (py3k). -- assignee: -> collinwinter resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue6032] Fix refleaks in test_urllib2_localnet

Daniel Diniz added the comment: LGTM :) This part changes the output in verbose mode, not sure it's necessary (but not a real problem either): -test_support.run_unittest(ProxyAuthTests) -test_support.run_unittest(TestUrlopen) +test_support.run_unittest(ProxyAuthTests, TestUrlopen)

[issue6032] Fix refleaks in test_urllib2_localnet

Collin Winter added the comment: Daniel, did you have any comments on this patch? If not, I'll go ahead and commit it and close both of these issues. -- ___ Python tracker ___ __

[issue6032] Fix refleaks in test_urllib2_localnet

Collin Winter added the comment: Yes, this is a patch for issue 6002 (sorry, didn't find it). I haven't seen any refleaks from issue 1208304, but I was only looking at this one particular failure (since it was showing up in Unladen Swallow's refleak builds). --

[issue6032] Fix refleaks in test_urllib2_localnet

Daniel Diniz added the comment: Collin, This the fix for issue 6002, right? Does issue 1208304 also cause leaks in your tests? -- dependencies: +test_urllib2_localnet DigestAuthHandler leaks nonces nosy: +ajaksu2 priority: -> normal ___ Python track

[issue6032] Fix refleaks in test_urllib2_localnet

New submission from Collin Winter : Currently (r72673), test_urllib2_localnet leaks references. This is due to state implicitly shared between tests. The attached patch fixes this by removing the shared state. The problem is also present in py3k. I'll port the patch once I commit to trunk. Shoul