[issue5883] detach() implementation

Benjamin Peterson added the comment: Applied in r72175. -- resolution: -> accepted status: open -> closed ___ Python tracker ___ ___

[issue5883] detach() implementation

Antoine Pitrou added the comment: The new patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5883] detach() implementation

Antoine Pitrou added the comment: > The various structures now contain several 'boolean' flags. It would > improve memory usage to use bitfields. Or would this impact performance > ? Those structures usually allocate a 4KB- or 8KB- buffer each, so I don't think squeezing two or three bytes wo

[issue5883] detach() implementation

Amaury Forgeot d'Arc added the comment: The various structures now contain several 'boolean' flags. It would improve memory usage to use bitfields. Or would this impact performance ? -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue5883] detach() implementation

Benjamin Peterson added the comment: Thanks for the review! New patch attached... -- Added file: http://bugs.python.org/file13824/detach.patch ___ Python tracker ___

[issue5883] detach() implementation

Antoine Pitrou added the comment: http://codereview.appspot.com/52075/diff/1/2 File Doc/library/io.rst (right): http://codereview.appspot.com/52075/diff/1/2#newcode366 Line 366: Disconnect this buffer from its underlying raw stream and return it. This sentence is a bit ambiguous. How about “Sep

[issue5883] detach() implementation

Antoine Pitrou added the comment: Reviewers: , Please review this at http://codereview.appspot.com/52075 Affected files: Doc/library/io.rst Lib/_pyio.py Lib/test/test_io.py Modules/_io/bufferedio.c Modules/_io/textio.c -- ___ Python

[issue5883] detach() implementation

Changes by Benjamin Peterson : Added file: http://bugs.python.org/file13821/detach.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue5883] detach() implementation

New submission from Benjamin Peterson : Here's the detach() implementation for BufferedIOBase and TextIOBase. -- assignee: benjamin.peterson components: IO files: detach.patch keywords: patch messages: 86830 nosy: benjamin.peterson, pitrou severity: normal status: open title: detach() im