[issue5846] Deprecate obsolete functions in unittest

Erlend E. Aasland added the comment: > It is an internal function. We can remove it without deprecation. How convenient :) -- ___ Python tracker ___ __

[issue5846] Deprecate obsolete functions in unittest

Serhiy Storchaka added the comment: It is an internal function. We can remove it without deprecation. -- ___ Python tracker ___ ___

[issue5846] Deprecate obsolete functions in unittest

Erlend E. Aasland added the comment: _makeLoader is not deprecated yet, so we might keep this open a little bit more. -- ___ Python tracker ___

[issue5846] Deprecate obsolete functions in unittest

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue5846] Deprecate obsolete functions in unittest

Change by Serhiy Storchaka : -- versions: +Python 3.11 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue5846] Deprecate obsolete functions in unittest

Serhiy Storchaka added the comment: New changeset b2b035a949eff1dc54b5bafe2bc9ce72b4d24438 by Serhiy Storchaka in branch 'main': bpo-5846: Fix deprecations for obsolete unittest functions and add tests. (GH-28382) https://github.com/python/cpython/commit/b2b035a949eff1dc54b5bafe2bc9ce72b4d24

[issue5846] Deprecate obsolete functions in unittest

Change by Serhiy Storchaka : -- pull_requests: +26797 pull_request: https://github.com/python/cpython/pull/28382 ___ Python tracker ___ _

[issue5846] Deprecate obsolete functions in unittest

Serhiy Storchaka added the comment: I do not think that PR 28299 is correct. We want to deprecate these functions which are implemented in the unittest.loader module, not just names exported to the unittest module. -- ___ Python tracker

[issue5846] Deprecate obsolete functions in unittest

Łukasz Langa added the comment: New changeset ff6d2cc55aac5cc53e331cae145d0cf35ec647b0 by Erlend Egeberg Aasland in branch 'main': bpo-5846: Deprecate obsolete methods in `unittest` (GH-28299) https://github.com/python/cpython/commit/ff6d2cc55aac5cc53e331cae145d0cf35ec647b0 -- nosy:

[issue5846] Deprecate obsolete functions in unittest

Serhiy Storchaka added the comment: New changeset 851811f5772c43f72f445e2ce1ac3ea9da951ae3 by Serhiy Storchaka in branch 'main': bpo-5846: Do not use obsolete unittest functions. (GH-28303) https://github.com/python/cpython/commit/851811f5772c43f72f445e2ce1ac3ea9da951ae3 -- ___

[issue5846] Deprecate obsolete functions in unittest

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 4.0 -> 5.0 pull_requests: +26717 pull_request: https://github.com/python/cpython/pull/28303 ___ Python tracker __

[issue5846] Deprecate obsolete functions in unittest

Change by Erlend E. Aasland : -- pull_requests: +26713 pull_request: https://github.com/python/cpython/pull/28299 ___ Python tracker ___

[issue5846] Deprecate obsolete functions in unittest

Erlend Egeberg Aasland added the comment: > I'm sure Gerhard wouldn't say no to changing the sqlite3 test prefix to "test_"... FYI, the sqlite3 tests have now been cleaned up (GH-20538). Remaining occurrences in Lib/test: Lib/test/test_pdb.py:unittest.makeSuite(PdbTestCase), Lib/test/

[issue5846] Deprecate obsolete functions in unittest

Change by Erlend Egeberg Aasland : -- keywords: +patch nosy: +erlendaasland nosy_count: 3.0 -> 4.0 pull_requests: +19663 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/20400 ___ Python tracker

[issue5846] Deprecate obsolete functions in unittest

Changes by Ezio Melotti : -- type: -> enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue5846] Deprecate obsolete functions in unittest

Changes by Ezio Melotti : -- stage: -> needs patch versions: +Python 3.3 -Python 2.7, Python 3.1 ___ Python tracker ___ ___ Python-bug

[issue5846] Deprecate obsolete functions in unittest

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5846] Deprecate obsolete functions in unittest

Michael Foord added the comment: Hehe - I wasn't actually doing that, just replacing the use of the obsolete functions. -- ___ Python tracker ___

[issue5846] Deprecate obsolete functions in unittest

Georg Brandl added the comment: I'm sure Gerhard wouldn't say no to changing the sqlite3 test prefix to "test_"... -- ___ Python tracker ___ _

[issue5846] Deprecate obsolete functions in unittest

Michael Foord added the comment: So it turns out that unittest.makeSuite is used about 100 times throughout the standard library tests. More than half the time it can be replaced with unittest.TestLoader().loadTestsFromTestCase(...) Some of the other times a loader needs to be constructed and

[issue5846] Deprecate obsolete functions in unittest

Georg Brandl added the comment: I guess adding a standard DeprecationWarning is fine in these cases. -- nosy: +georg.brandl ___ Python tracker ___ ___

[issue5846] Deprecate obsolete functions in unittest

New submission from Michael Foord : _makeLoader, getTestCaseNames, makeSuite and findTestCases have all had the comment "these functions should be considered obsolete" for a long time. Is is ok to go straight to deprecation or should they be marked with PendingDeprecationWarning first?