[issue5734] BufferedRWPair broken

2009-04-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've uploaded the patch for code review here: http://codereview.appspot.com/40126 -- ___ Python tracker ___

[issue5734] BufferedRWPair broken

2009-04-11 Thread Brian Quinlan
Brian Quinlan added the comment: Hey Antoine, Will do - but first I'll finish up my reason for needing a working version of this class in the first place ;-) Cheers, Brian -- ___ Python tracker __

[issue5734] BufferedRWPair broken

2009-04-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hey, thanks a lot for caring. I'll take a look at the patch and come back later. If you want to add some more tests, you are welcome too :-) -- assignee: -> pitrou nosy: +pitrou priority: -> release blocker stage: -> patch review ___

[issue5734] BufferedRWPair broken

2009-04-11 Thread Brian Quinlan
Changes by Brian Quinlan : -- components: +Library (Lib) type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue5734] BufferedRWPair broken

2009-04-11 Thread Brian Quinlan
New submission from Brian Quinlan : The C implementation: - doesn't correctly initialize its reader and writer instances - incorrectly maps its "readinto" method to another class - incorrectly delegates its "closed" property to its base class i.e. this class can't be used at all The Python impl