[issue5696] test_telnetlib augmentation

Jack Diederich added the comment: except when it doesn't! Still failing on some buildbots. The couple places where it expects 1% wibble in timing is far too strict. I'm fixing it. -- ___ Python tracker _

[issue5696] test_telnetlib augmentation

Benjamin Peterson added the comment: 2009/4/7 Jack Diederich : > > Jack Diederich added the comment: > > committed some changes in r71377.  This uses Queue.join() to [hopefully] > eliminate the race condidtions. Thanks! Works like a charm now. -- _

[issue5696] test_telnetlib augmentation

Jack Diederich added the comment: committed some changes in r71377. This uses Queue.join() to [hopefully] eliminate the race condidtions. -- ___ Python tracker ___ _

[issue5696] test_telnetlib augmentation

Benjamin Peterson added the comment: 2009/4/7 Jack Diederich : > > Jack Diederich added the comment: > > Could you try increasing self.blocking_timeout (in the _setUp function) > to something greater than 0.0 (like 0.1) and see if that works?  I > picked a constant that was as small as Worked F

[issue5696] test_telnetlib augmentation

Jack Diederich added the comment: Could you try increasing self.blocking_timeout (in the _setUp function) to something greater than 0.0 (like 0.1) and see if that works? I picked a constant that was as small as Worked For Me to keep the total test time as short as possible. Unfortunately selec

[issue5696] test_telnetlib augmentation

Benjamin Peterson added the comment: Jack, this test seems to be very flaky on the buildbots (and my machine). I see a lot of failures like this: == FAIL: test_read_eager_B (test.test_telnetlib.ReadTests) --

[issue5696] test_telnetlib augmentation

Jack Diederich added the comment: committed in r71302 -- resolution: -> accepted status: open -> closed ___ Python tracker ___ ___ Py

[issue5696] test_telnetlib augmentation

Changes by Jack Diederich : -- components: +Tests stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.1 ___ Python tracker ___ _

[issue5696] test_telnetlib augmentation

Changes by Jack Diederich : Removed file: http://bugs.python.org/file13617/test_telnetlib.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue5696] test_telnetlib augmentation

Jack Diederich added the comment: added some tests for testing IAC commands and SB data handling. -- Added file: http://bugs.python.org/file13624/test_telnetlib.patch ___ Python tracker

[issue5696] test_telnetlib augmentation

Georg Brandl added the comment: FWIW, it works here too with 0.0 and 0.1 seconds (it's Linux x86). -- nosy: +georg.brandl ___ Python tracker ___ _

[issue5696] test_telnetlib augmentation

New submission from Jack Diederich : The first part of my telnetlib work is testing what already is. Attached is a patch to test_telnetlib that tests mosts of the guarantees of the telnetlib.Telnet.read_* methods (as guaranteed by the docs, at least). Theoretically every test I added has a race