[issue5682] Move io-in-c modules into a subdirectory of Modules/

Alexandre Vassalotti added the comment: Committed in r71185. Thanks Antoine for the review! -- resolution: -> accepted status: open -> closed ___ Python tracker ___ ___

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: You should commit. If there is a problem with other Windows build files, it will certainly be noticed and fixed by a true Windows developer. -- ___ Python tracker _

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Alexandre Vassalotti added the comment: Thanks! Here is the updated patch. -- Added file: http://bugs.python.org/file13607/move-iomodule-in-subdir-4.diff ___ Python tracker ___ _

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: After also renaming the files, there is a slight bug in PCbuild/pythoncore.vcproj. Here is a subpatch incorporating the changes to this only file. -- Added file: http://bugs.python.org/file13606/pythoncore.patch ___

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: Or perhaps these are really meant as the new file names? Initially I thought the purpose was initially to move the files into a subdir. -- ___ Python tracker __

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: Some failures: _iomodule.c c1 : fatal error C1083: Impossible d'ouvrir le fichier source : '..\..\Modules\_io\_iomodule.c' : No such file or directory textio.c c1 : fatal error C1083: Impossible d'ouvrir le fichier source : '..\..\Modules\_io\textio.c' : No suc

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: > Have you tested PCbuild changes? As, this is the part I am the most > unsure about. Ok, unless someone beats me to it, I'm gonna fire a Windows VM and test this. -- ___ Python tracker

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Alexandre Vassalotti added the comment: Have you tested PCbuild changes? As, this is the part I am the most unsure about. -- ___ Python tracker ___ __

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: I think you can commit! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Changes by Alexandre Vassalotti : Removed file: http://bugs.python.org/file13604/move-iomodule-in-subdir-2.diff ___ Python tracker ___ ___ Pyth

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Changes by Alexandre Vassalotti : Removed file: http://bugs.python.org/file13602/move-iomodule-in-subdir.diff ___ Python tracker ___ ___ Python

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Alexandre Vassalotti added the comment: Antoine wrote: > - in Makefile.pre.in, it seems the IO_OBJS definition might need updating I updated the patch to also fix IO_OBJS. Also, I added stringio.c to IO_OBJS. > Please note, when committing, it would be good to use "svn mv" for the > actual mo

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Alexandre Vassalotti added the comment: Antoine, you're too quick. :-) By the way, the patch is fairly large due to the renaming. So, here's quick-and-dirty summary of the important changes. PCbuild/pythoncore.vcproj: Renamed the paths and added a tag for the _io directory. PC/VS7.1/pytho

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: Some comments: - there are some unrelated pickle changes in your patch - in Makefile.pre.in, it seems the IO_OBJS definition might need updating Otherwise I don't have any objections. Please note, when committing, it would be good to use "svn mv" for the actual

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Changes by Alexandre Vassalotti : Added file: http://bugs.python.org/file13602/move-iomodule-in-subdir.diff ___ Python tracker ___ ___ Python-b

[issue5682] Move io-in-c modules into a subdirectory of Modules/

Antoine Pitrou added the comment: Where's the patch? -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue5682] Move io-in-c modules into a subdirectory of Modules/

New submission from Alexandre Vassalotti : Here is a patch that moves the source files of the _io module (and closely related modules) into subdirectory of Modules. The new file hierarchy proposed is the following: Modules/ _io/ _iomodule.h _iomodule.c iobase.c file