[issue5559] IDLE Output Window 's goto fails when path has spaces

Kurt B. Kaiser added the comment: Backported to 2.6 4Oct09 56387:490190cb4a57 -- stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue5559] IDLE Output Window 's goto fails when path has spaces

R. David Murray added the comment: I think the issue is still open waiting for a unit test. On the other hand, how likely is it that someone is going to write one at this point? If someone doesn't speak up soon I think you can close it. -- nosy: +r.david.murray

[issue5559] IDLE Output Window 's goto fails when path has spaces

Terry J. Reedy added the comment: Resolution should only be set when an issue is closed. So should this be closed? or unfixed and the versions updated? -- nosy: +tjreedy ___ Python tracker

[issue5559] IDLE Output Window 's goto fails when path has spaces

Claudio Canepa added the comment: On Sat, May 2, 2009 at 11:31 PM, Kurt B. Kaiser wrote: > > Kurt B. Kaiser added the comment: > > r72227. > > How's your test code coming? A relative Win filename with leading > spaces should be found even when there's a file of same name but no > spaces. > >

[issue5559] IDLE Output Window 's goto fails when path has spaces

Kurt B. Kaiser added the comment: r72227. How's your test code coming? A relative Win filename with leading spaces should be found even when there's a file of same name but no spaces. -- keywords: +26backport ___ Python tracker

[issue5559] IDLE Output Window 's goto fails when path has spaces

Guilherme Polo added the comment: > Do you have a case the corrected code doesn't handle? Create a file that starts with a space and search for something that returns it, for example. -- ___ Python tracker ___

[issue5559] IDLE Output Window 's goto fails when path has spaces

Kurt B. Kaiser added the comment: I'd welcome a test, please provide one. I actually wrote a small test code so I could understand the problem, but didn't include it. The 'grep dialog' sends its output to an OutputWindow labelled *Output* as a series of lines. This is entirely separate from

[issue5559] IDLE Output Window 's goto fails when path has spaces

Guilherme Polo added the comment: Wouldn't it be better to actually write tests for it ? Also, the issue's title is a bit misleading, it is not only spaces that causes troubles. Isn't fixing how GrepDialog <-> OutputWindow works an acceptable solution ? Instead of just writing the output in the

[issue5559] IDLE Output Window 's goto fails when path has spaces

Kurt B. Kaiser added the comment: Added a regex to handle win paths w/spaces. A regex match may not be the file desired. Try all the patterns until a valid file is found. r71995. Let me know if you can find a failing corner case. port to 3 and -maint. -- assignee: -> kbk nosy: +kbk

[issue5559] IDLE Output Window 's goto fails when path has spaces

Claudio Canepa added the comment: On a second look: 1. the code in OutputWindow.py for the 'goto' action looks for a match with the first regex in file_line_pats = [ r'file "([^"]*)", line (\d+)', r'([^\s]+)\((\d+)\)', r'([^\s]+):\s*(\d+):', ] and it assumes the

[issue5559] IDLE Output Window 's goto fails when path has spaces

Guilherme Polo added the comment: I see this occurring everywhere, but the proposed solution may not be enough. I can still create a directory with a tab on it and it will fail too. The proper solution (in my head) would involve changing the interaction of GrepDialog with OutupWindow, but then

[issue5559] IDLE Output Window 's goto fails when path has spaces

New submission from Claudio Canepa : in windows XP, python 2.6.1, 2.6 , python 2.4 1. do an Edit | 'Find in files' [ it pop ups the Output Window with result] 2. Right click over one of the target lines found, click the 'goto file \line' pop up If the path in the target line has spaces, it will