[issue5544] test_fileio fails on windows MSVC Assertion

Changes by Mark Lawrence : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5544] test_fileio fails on windows MSVC Assertion

Mark Lawrence added the comment: Closed as stated fixed in revision 70582. -- nosy: +BreamoreBoy resolution: -> fixed stage: -> committed/rejected ___ Python tracker ___ __

[issue5544] test_fileio fails on windows MSVC Assertion

Antoine Pitrou added the comment: Basically, all FileIO methods should be protected (I'm not even sure why you are asking! we can't let the interpreter crash rather than raise an exception). Someone has to write additional tests for those though, for now only close() is tested. --

[issue5544] test_fileio fails on windows MSVC Assertion

Antoine Pitrou added the comment: The fix is wrong, it doesn't raise an error when the fd is invalid... -- ___ Python tracker ___ ___

[issue5544] test_fileio fails on windows MSVC Assertion

Andreas Schawo added the comment: r69214 works with os.close(f.fileno());f.close() (Exception with Errno 9) r69560 does not compile r70152 test_fileio failed (different reason) MSVC Assertion with os.close(f.fileno());f.close() I was not able to use _fileio.c from r69214 in cause of othe

[issue5544] test_fileio fails on windows MSVC Assertion

Antoine Pitrou added the comment: I can definitely reproduce the problem under a Windows XP virtual machine using Visual C++ 2008 Express in debug mode. Here is a screenshot. Unfortunately, I'm not a Windows programmer and I'm not able to produce a patch for this. But the close() call in _filei

[issue5544] test_fileio fails on windows MSVC Assertion

Andreas Schawo added the comment: I stepped back to r70187 and got no assertion. An update to r70349 result in an assertion. So I reverted the changes in test_fileio.py of r70349 and got no assertion. But the test should work without assertion. I tested releases 2.6.1, 3.0.1 and current trunk

[issue5544] test_fileio fails on windows MSVC Assertion

Antoine Pitrou added the comment: It is not strictly speaking "an error" which is causing the double close... It's the deliberate behaviour of a test I have added to check that errno is correctly set on the raised IOError when calling close() on a FileIO object whose handle has already been clos

[issue5544] test_fileio fails on windows MSVC Assertion

Antoine Pitrou added the comment: I wonder whether a magic assertion-disabling spell is needed around the call to close() in _fileio.c. Kristjan, do you have any insights on this? -- nosy: +krisvale, loewis ___ Python tracker

[issue5544] test_fileio fails on windows MSVC Assertion

Andreas Schawo added the comment: I'm afraid your patch doesn't solve it. I got the same popup: Debug Assertion Failed! Program: .\python_d.exe File: f:\dd\vctoools\crt_bld\self_x86\crt\src\close.c Line: 48 Expression: (_osfile(fh) & FOPEN) It failed while running testErrnoOnClose. I'm u