[issue5410] msvcrt bytes cleanup

Benjamin Peterson added the comment: Applied in r72185. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyt

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: > MSDN says _ungetwch returns WEOF instead of EOF when error occurs. Ok, I updated my patch (to use WEOF). -- Added file: http://bugs.python.org/file13718/msvcrt_wchar-2.patch ___ Python tracker

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: > I cannot see any remarks about masking behavior. :-( I asked on a french Windows developer channel. The answer is that the Windows terminal uses "ANSI" charset even if it's possible to use unicode. So it's a bug in Microsoft msvcrt library (directly in the

[issue5410] msvcrt bytes cleanup

Hirokazu Yamamoto added the comment: MSDN says _ungetwch returns WEOF instead of EOF when error occurs. http://msdn.microsoft.com/en-us/library/yezzac74(VS.80).aspx I cannot see any remarks about masking behavior. :-( -- ___ Python tracker

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: > There seems to be a problem with ungetwch() I tested Visual C++ Express 2008 and it looks like _ungetwch() only keep 8 lower bits (like _ungetwch(x & 255)). But it's a bug in Microsoft library, not in Python code (I added some printf to be sure). My patch

[issue5410] msvcrt bytes cleanup

Changes by Benjamin Peterson : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5410] msvcrt bytes cleanup

Benjamin Peterson added the comment: I think this can wait until the first beta. -- nosy: +benjamin.peterson priority: release blocker -> deferred blocker ___ Python tracker ___

[issue5410] msvcrt bytes cleanup

Antoine Pitrou added the comment: There seems to be a problem with ungetwch(): >>> s = msvcrt.getwch() # Here I type the Euro sign (€) >>> ascii(s) "'\\u20ac'" >>> msvcrt.ungetwch(s) >>> u = msvcrt.getwch() >>> ascii(u) "'\\xac'" -- nosy: +pitrou type: -> behavior ___

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: issue5499 is fixed, so msvcrt_wchar.patch can now be used :-) Anyone available for a review and/or _a test_? I don't have Windows, so it's hard for me to test my patch. -- ___ Python tracker

[issue5410] msvcrt bytes cleanup

Changes by Hirokazu Yamamoto : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5410] msvcrt bytes cleanup

Changes by Hirokazu Yamamoto : -- dependencies: +only accept byte for getarg('c') and unicode for getarg('C') ___ Python tracker ___ __

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: Patch implementing my proposition (depends on issue5499). -- Added file: http://bugs.python.org/file13351/msvcrt_wchar.patch ___ Python tracker

[issue5410] msvcrt bytes cleanup

STINNER Victor added the comment: > msvcrt.ungetwch() calls _ungetch not _ungetwch ... are you sure that someone already used these functions? :-) If you suppose that issue5499 is fixed, you can leave msvcrt_putch() and msvcrt_ungetch unchanged and use "C" format in msvcrt_ungetwch() ("Py_UN

[issue5410] msvcrt bytes cleanup

New submission from Hirokazu Yamamoto : I came from issue5391. Here is quote of Victor's message. >* msvcrt.putch(char), msvcrt.ungetch(char): msvcrt has also: > - msvcrt.getch()->byte string of 1 byte > - msvcrt.getwch()->unicode string of 1 character > - msvcrt.putwch(unicode string of 1 ch