[issue5306] Python 3.1 won't compile under Visual Studio 2005

Amaury Forgeot d'Arc added the comment: I merged the change manually, and came to the same patch as ocean-city; Then I noticed that os.device_encoding() (new in python 3.0) needs the same check as well. -- resolution: -> fixed status: open -> closed _

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Changes by Amaury Forgeot d'Arc : -- assignee: -> amaury.forgeotdarc nosy: +amaury.forgeotdarc ___ Python tracker ___ ___ Python-bugs-

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Benjamin Peterson added the comment: Could one of the Windows experts do the port? I can't properly resolve the conflicts or test the changes here. -- assignee: benjamin.peterson -> ___ Python tracker

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Kristján Valur Jónsson added the comment: Ah, I just saw this. Yes, looks like a missing file during porting. That should affect VS2008 as well. Cheers! ___ Python tracker ___ ___

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Changes by Raymond Hettinger : -- priority: high -> critical ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Raymond Hettinger added the comment: Benjamin, please use this patch to complete the merge. -- assignee: krisvale -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker ___

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Hirokazu Yamamoto added the comment: And I think r69268 should be merged too. ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Hirokazu Yamamoto added the comment: I think change for posixmodule.c is missing from r69495. (I confirmed other merges don't include posixmodule.c modification) Attached patch will fix this. (I don't have VS2005 or later, so I cannot test this on my machine) -- keywords: +patch nosy:

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Raymond Hettinger added the comment: Kristan, I think this is yours. -- assignee: -> krisvale nosy: +krisvale ___ Python tracker ___

[issue5306] Python 3.1 won't compile under Visual Studio 2005

Martin v. Löwis added the comment: I don't feel responsible for VS2005 support. Unassigning myself. -- assignee: loewis -> ___ Python tracker ___ ___

[issue5306] Python 3.1 won't compile under Visual Studio 2005

New submission from Raymond Hettinger : This started happening a few days ago, about when Benjamin forward ported r69560 . There is an #ifdef in fileobject.h that makes a header for int _PyVerify_fd(int fd) but does not define it. It is likely related to r69495 . _fileio.obj : error LNK2019: u