[issue5249] Fix strftime on windows.

Changes by Martin v. Löwis : -- priority: -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5249] Fix strftime on windows.

Hirokazu Yamamoto added the comment: Thanks, fixed in r69664(py3k) and r69665(release30-maint). -- priority: high -> resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue5249] Fix strftime on windows.

Martin v. Löwis added the comment: Using TZNAME_ENCODING is fine; I just think it has an incorrect value on Unix. All in all, I think the (original) patch is fine, please apply. -- resolution: -> accepted ___ Python tracker

[issue5249] Fix strftime on windows.

Hirokazu Yamamoto added the comment: Locale is my weak point. :-( If there is locale encoding function like PyUnicode_DecodeFSDefault for file system encoding, I think I can use it. ___ Python tracker __

[issue5249] Fix strftime on windows.

Martin v. Löwis added the comment: > On VC6, wcsftime simply converts *format* to mbcs string, calls > strftime, and converts result to unicode, so there is no difference > between my patch and wcsftime. Right. > (Newer VC's wcsftime might have different > implementation though) Maybe you are

[issue5249] Fix strftime on windows.

Hirokazu Yamamoto added the comment: Sorry, if we use wcsftime, I cannot create the patch. On VC6, wcsftime returns not unicode but mbcs string which copied to wchar array. Maybe on snakebite.org, I can access VC9 and confirm its behavior on it? ;-) ___ Pyth

[issue5249] Fix strftime on windows.

Changes by Hirokazu Yamamoto : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/pyt

[issue5249] Fix strftime on windows.

Hirokazu Yamamoto added the comment: I experimentally implemented with wcsftime, but I couldn't get same result as strftime + mbcs conversion. Probably because wcsftime depends on locale. Added file: http://bugs.python.org/file13079/experimental_wcsftime.patch _

[issue5249] Fix strftime on windows.

Hirokazu Yamamoto added the comment: On VC6, wcsftime simply converts *format* to mbcs string, calls strftime, and converts result to unicode, so there is no difference between my patch and wcsftime. (Newer VC's wcsftime might have different implementation though) Maybe you are concerning about

[issue5249] Fix strftime on windows.

Martin v. Löwis added the comment: I think we should use wcsftime on Windows, even though it works very similar to your patch (with the primary difference being that it uses alloca instead of Py_Malloc). -- nosy: +loewis ___ Python tracker

[issue5249] Fix strftime on windows.

Changes by Kevin Watters : -- nosy: +kevinwatters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue5249] Fix strftime on windows.

Changes by Hirokazu Yamamoto : -- priority: -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5249] Fix strftime on windows.

New submission from Hirokazu Yamamoto : On windows, format string should be encoded as mbcs. Otherwise, result of strftime would be broken. Here is the patch. -- components: Extension Modules, Windows files: fix_strftime_on_windows.patch keywords: patch messages: 81946 nosy: ocean-city s