[issue5236] time.strptime should reject bytes arguments on Py3

Brett Cannon added the comment: Applied in r70755 for py3k. I am not backporting as I changed it to explicitly check both arguments which is a change in semantics. -- resolution: -> accepted status: open -> closed versions: -Python 3.0 ___ Python t

[issue5236] time.strptime should reject bytes arguments on Py3

Brett Cannon added the comment: I am going to do a review at http://codereview.appspot.com/28147 ; not done yet. -- ___ Python tracker ___ ___

[issue5236] time.strptime should reject bytes arguments on Py3

Changes by Tennessee Leeuwenburg : Added file: http://bugs.python.org/file13355/strptime_patch_v2.txt ___ Python tracker ___ ___ Python-bugs-li

[issue5236] time.strptime should reject bytes arguments on Py3

Tennessee Leeuwenburg added the comment: Thanks for the comments all and sorry for the delay -- life! -- ___ Python tracker ___ ___ Py

[issue5236] time.strptime should reject bytes arguments on Py3

Amaury Forgeot d'Arc added the comment: Please remove the whitespace changes in the patch (around "_cache_lock"). Otherwise it is good. -- nosy: +amaury.forgeotdarc ___ Python tracker _

[issue5236] time.strptime should reject bytes arguments on Py3

Changes by Tennessee Leeuwenburg : -- stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue5236] time.strptime should reject bytes arguments on Py3

Tennessee Leeuwenburg added the comment: Python implementation to raise this exception if a bytes argument is passed in as argument 1. Test case added to test_time -- Added file: http://bugs.python.org/file13311/strptime_patch.txt ___ Python tracker

[issue5236] time.strptime should reject bytes arguments on Py3

Brett Cannon added the comment: If you want to work on it, Tennesse, then go for it! -- components: +Library (Lib) -Extension Modules priority: -> normal ___ Python tracker ___

[issue5236] time.strptime should reject bytes arguments on Py3

Tennessee Leeuwenburg added the comment: See also thread http://mail.python.org/pipermail/python-dev/2009-March/087104.html -- ___ Python tracker ___

[issue5236] time.strptime should reject bytes arguments on Py3

Tennessee Leeuwenburg added the comment: My mistake, it is part of the Lib component ... I failed to see the callback to Python from timemodule.c and jumped to conclusions. In any case, I'm happy to work on this. -- ___ Python tracker

[issue5236] time.strptime should reject bytes arguments on Py3

Tennessee Leeuwenburg added the comment: I believe this shouldn't be tagged as part of the Lib component... Also, I am happy to work on this issue, developing tests and a patch. Would that be appropriate? I may take a little while to get the hang of things, but I'm happy to put some time into t

[issue5236] time.strptime should reject bytes arguments on Py3

Changes by Brett Cannon : -- assignee: -> brett.cannon nosy: +brett.cannon stage: -> test needed ___ Python tracker ___ ___ Python-bu

[issue5236] time.strptime should reject bytes arguments on Py3

New submission from Ezio Melotti : On Python3 time.strptime(string[, format]) accepts bytes as arguments and then fails: >>> strptime(b"2009", "%Y") Traceback (most recent call last): File "", line 1, in File "C:\Programs\Python30\lib\_strptime.py", line 454, in _strptime_time return _s