[issue5134] Compiler warnings in sqlite module

Martin v. Löwis added the comment: Fixed in r69489, r69490, r69491, r69492, r69493. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue5134] Compiler warnings in sqlite module

Ulrich Eckhardt added the comment: "What specific file would you put these pragmas into? Are you perhaps proposing to change upstream code?" I would put it into the only sourcefile there is, and yes, I would change upstream code. Obviously, it would be better to get upstream to incorporate thos

[issue5134] Compiler warnings in sqlite module

Martin v. Löwis added the comment: Here is a patch that works similar to sqlite3_warnings, but moves all sqlite3.dll settings into a separate property file. Added file: http://bugs.python.org/file12968/sqlite.patch ___ Python tracker

[issue5134] Compiler warnings in sqlite module

Martin v. Löwis added the comment: > My approach for disabling the > warnings in the code has (to me) two advantages: What specific file would you put these pragmas into? Are you perhaps proposing to change upstream code? ___ Python tracker

[issue5134] Compiler warnings in sqlite module

Ulrich Eckhardt added the comment: Technically, both changes (or neither of them) generate the same output binaries, so I Don't Care(tm). My approach for disabling the warnings in the code has (to me) two advantages: 1. You immediately see that warnings are disabled. I would otherwise never e

[issue5134] Compiler warnings in sqlite module

Martin v. Löwis added the comment: > The syntax would be this: > > #if defined(_MSC_VER) > # pragma warning(push) >/* Disable warnings for this file, see >http://www.sqlite.org/faq.html#q17 why we don't care for them. */ > # pragma warning(disable: 4244) > # pragma warning(disable: 4

[issue5134] Compiler warnings in sqlite module

Ulrich Eckhardt added the comment: The syntax would be this: #if defined(_MSC_VER) # pragma warning(push) /* Disable warnings for this file, see http://www.sqlite.org/faq.html#q17 why we don't care for them. */ # pragma warning(disable: 4244) # pragma warning(disable: 4018) #endif ...

[issue5134] Compiler warnings in sqlite module

Amaury Forgeot d'Arc added the comment: The attached patch sets the /W1 flag for the sqlite3 project. -- keywords: +patch nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file12928/sqlite3_warnings.patch ___ Python tracker

[issue5134] Compiler warnings in sqlite module

Gerhard Häring added the comment: I propose to either close this as wontfix. I don't know the switches for the Microsoft compiler to disable the warnings myself. ___ Python tracker ___ __

[issue5134] Compiler warnings in sqlite module

Raymond Hettinger added the comment: Martin, if you can find a way to silence the compiler for the upstream code that would be great. If not, go ahead and close as won't fix. -- assignee: ghaering -> loewis ___ Python tracker

[issue5134] Compiler warnings in sqlite module

Gerhard Häring added the comment: This is a known issue with SQLite. It's not as bad as it looks at first sight, though. http://www.sqlite.org/faq.html#q17 """ (17) I get hundreds of compiler warnings when I compile SQLite. Isn't this a problem? Doesn't it indicate poor code quality? Quality

[issue5134] Compiler warnings in sqlite module

Martin v. Löwis added the comment: I don't think we should do anything about these, except perhaps for disabling all warnings when compiling the file. These are upstream sources, so we definitely should not "fix" them. -- nosy: +loewis ___ Python tra

[issue5134] Compiler warnings in sqlite module

New submission from Raymond Hettinger : >From a compilation of Py3.1 r69209 : ..\..\..\sqlite-3.5.9\sqlite3.c(9702) : warning C4244: '=' : conversion from 'double' to 'int', possible loss of data ..\..\..\sqlite-3.5.9\sqlite3.c(9703) : warning C4244: '=' : conversion from 'double' to 'int', poss