[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: I suppose this can be closed now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: New changeset bd73e72b4a9f019be514954b1d40e64dc3a5e81c by Antoine Pitrou (Allen W. Smith, Ph.D) in branch 'master': bpo-5001: More-informative multiprocessing error messages (#3079) https://github.com/python/cpython/commit/bd73e72b4a9f019be514954b1d40e64dc3a5e8

[issue5001] Remove assertion-based checking in multiprocessing

drallensmith added the comment: I've updated the PR to include all of the non-Windows-specific asserts; I am not sufficiently familiar with Windows multiprocessing to feel confident writing informative error messages. -- ___ Python tracker

[issue5001] Remove assertion-based checking in multiprocessing

drallensmith added the comment: Sorry! I was starting to wonder if the PR had been overlooked somehow... -- ___ Python tracker ___ ___

[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: Please allow us a bit of time :-) We are all volunteers here. -- ___ Python tracker ___ ___ Python-b

[issue5001] Remove assertion-based checking in multiprocessing

drallensmith added the comment: No discussion yet on pull request (5 days); just submitted fixes for util.py. -- ___ Python tracker ___ ___

[issue5001] Remove assertion-based checking in multiprocessing

drallensmith added the comment: Pull request submitted (4 days ago) for managers.py, queue.py; just added pool.py changes to those. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker __

[issue5001] Remove assertion-based checking in multiprocessing

Changes by drallensmith : -- pull_requests: +3120 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: New changeset 48d9823a0ebde4dfab8bc154bb6df462fb2ee403 by Antoine Pitrou (Allen W. Smith, Ph.D) in branch 'master': bpo-5001, bpo-31169: Fix two uninformative asserts in multiprocessing/managers.py (#3078) https://github.com/python/cpython/commit/48d9823a0ebde

[issue5001] Remove assertion-based checking in multiprocessing

Changes by drallensmith : -- pull_requests: +3117 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue5001] Remove assertion-based checking in multiprocessing

drallensmith added the comment: Patches (for 2.7 and 3.5; the code is identical, only the line numbers changed) for the portion I commented on can be found in issue 31169. -- ___ Python tracker

[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: @drallensmith, the patch you commented on is very old and probably doesn't apply anymore. It would be useful to make an updated patch (or rather PR, as we are using Github for development now: see https://devguide.python.org/pullrequest/). -- __

[issue5001] Remove assertion-based checking in multiprocessing

Changes by drallensmith : -- nosy: +drallensmith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue5001] Remove assertion-based checking in multiprocessing

Changes by Camilla Montonen : -- nosy: +Winterflower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue5001] Remove assertion-based checking in multiprocessing

Changes by Berker Peksag : -- nosy: +berker.peksag type: -> enhancement versions: +Python 3.6 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ _

[issue5001] Remove assertion-based checking in multiprocessing

Changes by Ned Deily : -- nosy: +sbt versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-l

[issue5001] Remove assertion-based checking in multiprocessing

Jessica McKellar added the comment: Thanks for the patches, vladris! I've reviewed the latest version, and it addresses all of Antoine's review feedback. Ezio left some additional feedback (http://bugs.python.org/review/5001/#ps3407) which still needs to be addressed. -- nosy: +jesste

[issue5001] Remove assertion-based checking in multiprocessing

Vlad Riscutia added the comment: Thanks for the quick review! I attached second iteration addressing feedback + changed all occurrences of checks like "type(x) is y" to "isinstance(x, y)". I would appreciate a second look because this patch has many small changes and even though I ran full te

[issue5001] Remove assertion-based checking in multiprocessing

Antoine Pitrou added the comment: Thank you. I've attached some comments, click on the "review" link to read them. -- assignee: jnoller -> nosy: +pitrou -BreamoreBoy stage: needs patch -> patch review versions: +Python 3.3 -Python 3.1 ___ Python tra

[issue5001] Remove assertion-based checking in multiprocessing

Vlad Riscutia added the comment: I attached a patch which replaces all asserts with checks that raise exceptions. I used my judgement in determining exception types but I might have been off in some places. Also, this patch replaces ALL asserts. It is possible that some of the internal functi

[issue5001] Remove assertion-based checking in multiprocessing

Jesse Noller added the comment: @Mark Yeah - I'm the current multiprocessing maintainer. If I fix it, I'll just commit it :) I filed this as a to do against myself. -- ___ Python tracker __

[issue5001] Remove assertion-based checking in multiprocessing

Mark Lawrence added the comment: @Jesse: could you provide a patch that addresses this issue? -- nosy: +BreamoreBoy stage: -> needs patch versions: +Python 3.2 ___ Python tracker __

[issue5001] Remove assertion-based checking in multiprocessing

New submission from Jesse Noller : Right now, the multiprocessing code is littered with statements like: assert self._popen is None, 'cannot start a process twice' assert self._parent_pid == os.getpid(), \ 'can only start a process object created by current proces