[issue4978] allow unicode keyword args

Benjamin Peterson added the comment: Done in r78027. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python

[issue4978] allow unicode keyword args

Barry A. Warsaw added the comment: Maybe not. It's arguably a bug that adding unicode_literals breaks keyword arguments. Guido seems to (mostly) agree that it's a bug we just never got around to fixing. http://www.mail-archive.com/python-...@python.org/msg45346.html -- ___

[issue4978] allow unicode keyword args

Amaury Forgeot d'Arc added the comment: Why backport? Isn't this a new feature? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue4978] allow unicode keyword args

Barry A. Warsaw added the comment: release blocker for 2.6.5 -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-l

[issue4978] allow unicode keyword args

Barry A. Warsaw added the comment: Really trivial back port of r68805 from trunk. -- assignee: -> benjamin.peterson components: +Interpreter Core -Library (Lib) keywords: +needs review resolution: accepted -> stage: -> patch review status: closed -> open type: feature request -> beha

[issue4978] allow unicode keyword args

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue4978] allow unicode keyword args

Benjamin Peterson added the comment: Thanks for the reviews! Applied in r68805. -- resolution: -> accepted status: open -> closed ___ Python tracker ___

[issue4978] allow unicode keyword args

Amaury Forgeot d'Arc added the comment: The patch looks good now. ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue4978] allow unicode keyword args

Benjamin Peterson added the comment: Interesting, I didn't know that about _PyUnicode_AsDefaultEncodedString. Here's another patch. Added file: http://bugs.python.org/file12805/unicode_kwargs3.patch ___ Python tracker

[issue4978] allow unicode keyword args

Amaury Forgeot d'Arc added the comment: Sorry, but _PyUnicode_AsDefaultEncodedString returns either a borrowed reference (if errors==NULL) or a new reference (if errors!=NULL). In either case it's wrong to DECREF the string when you simply take the buffer's address: >>> f(**{u'someLongStrin

[issue4978] allow unicode keyword args

Benjamin Peterson added the comment: This patch should fix that. Added file: http://bugs.python.org/file12801/unicode_keyword_args.patch ___ Python tracker ___ __

[issue4978] allow unicode keyword args

Amaury Forgeot d'Arc added the comment: The patch works when the unicode contains only ascii, but crashes with the following input: >>> def f(hehe): return 42 ... >>> f(**{u'hehe': 1}) 42 >>> f(**{u'héhé': 1}) Segmentation fault The two PyString_AsString(keyword) calls are now wrong and shoul

[issue4978] allow unicode keyword args

Changes by Benjamin Peterson : -- keywords: +patch Added file: http://bugs.python.org/file12782/unicode_kwds.patch ___ Python tracker ___ _

[issue4978] allow unicode keyword args

New submission from Benjamin Peterson : This allows unicode arguments to be passed as keywords to functions to help "from __future__ import unicode_literals". See http://mail.python.org/pipermail/python-dev/2009-January/085113.html. -- components: Library (Lib) messages: 80060 nosy: benj