[issue4932] Little improvement on urlparse module, urlparse function.

Senthil Kumaran added the comment: I reviewed the patch and we may not go with it. - There is recent improvements in parsing and the patch does not go well with it, especially the clear_cache removal. Also there is a mistake in the patch: -scheme, url = url[:i].lower(), url[i+1:]

[issue4932] Little improvement on urlparse module, urlparse function.

Mark Lawrence added the comment: Andres, do you wish to provide more patches or can we close this issue? -- nosy: +BreamoreBoy ___ Python tracker ___

[issue4932] Little improvement on urlparse module, urlparse function.

Changes by Daniel Diniz : -- nosy: +jjlee ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue4932] Little improvement on urlparse module, urlparse function.

Changes by Daniel Diniz : -- nosy: +orsenthil stage: -> test needed versions: +Python 2.7 -Python 2.5 ___ Python tracker ___ ___ Pytho

[issue4932] Little improvement on urlparse module, urlparse function.

Andres Moreira added the comment: Yes are micro-optimizations, but when I parsed a lot of url(10.000 or more) that 10% or 8% or 5% is very well for me :). It was little contribution to that module, anyway, i think that there are more optimizatoins to do but I will try to do it then. ___

[issue4932] Little improvement on urlparse module, urlparse function.

STINNER Victor added the comment: > Now I attach the patch. Your first patch for Python 2.5 was interesting, and looked close to the python 2.6 version. But your second patch (for 2.6) contains only micro-optimisations: - inline the one-line clear_cache() function - replace "scheme, url = .

[issue4932] Little improvement on urlparse module, urlparse function.

Andres Moreira added the comment: Hi haypo, sorry for submit all the file, it's my first time here and I'm not very used to this process yet. :) Now I attach the patch. -- keywords: +patch Added file: http://bugs.python.org/file12744/urlparse.patch ___

[issue4932] Little improvement on urlparse module, urlparse function.

Andres Moreira added the comment: And that is the profile code. Added file: http://bugs.python.org/file12743/profile_urlparse.py ___ Python tracker ___ __

[issue4932] Little improvement on urlparse module, urlparse function.

STINNER Victor added the comment: Please, attach patches instead of the full file. ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue4932] Little improvement on urlparse module, urlparse function.

Andres Moreira added the comment: Hi haypo, Ok I've been testing with python 2.6 and I put the results here: optimizedurlparse is the file with my patch First test optimizedurlparse, second urlparse: #:/opt/python2.6/release26-maint$ ./python mio/profile_urlparse.py timing optimizedurlpars

[issue4932] Little improvement on urlparse module, urlparse function.

STINNER Victor added the comment: It looks like most of your changes are already part of urlparse module of Python 2.6. Can you port your patch to Python 2.6 and retry your benchmark on Python 2.6? -- nosy: +haypo ___ Python tracker

[issue4932] Little improvement on urlparse module, urlparse function.

New submission from Andres Moreira : Hi, I make a little change in the urlsplit function of urlparse module. And the performance when I'm parsing a lot of urls was improved a bit. In the best case was improved around a 20% percent. Python version: 2.5.2 (r252:60911, Oct 5 2008, 19:29:17) [GC