[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2013-10-25 Thread Tim Golden
Tim Golden added the comment: Fixed on tip. Thanks for the issue and the original patch. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2013-10-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 66398e1307f4 by Tim Golden in branch 'default': Issue4905: use INVALID_FILE_ATTRIBUTES where appropriate. (Patch by Ulrich Eckhardt) http://hg.python.org/cpython/rev/66398e1307f4 -- nosy: +python-dev ___

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2013-10-24 Thread Tim Golden
Changes by Tim Golden : -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2013-10-24 Thread Tim Golden
Changes by Tim Golden : -- assignee: -> tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2010-09-03 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- components: +Extension Modules, Windows -Interpreter Core nosy: +brian.curtin, tim.golden stage: -> patch review versions: +Python 3.2 -Python 2.7 ___ Python tracker _

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2009-01-12 Thread Gabriel Genellina
Gabriel Genellina added the comment: The patch looks fine to me -- nosy: +gagenellina ___ Python tracker ___ ___ Python-bugs-list mail

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2009-01-10 Thread Ulrich Eckhardt
Ulrich Eckhardt added the comment: The patch replaces remaining magic numbers with INVALID_FILE_ATTRIBUTES. -- keywords: +patch Added file: http://bugs.python.org/file12673/python-2.7-fileattrib-magic.0.patch ___ Python tracker

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

2009-01-10 Thread Ulrich Eckhardt
New submission from Ulrich Eckhardt : GetFileAttributes[W|A] returns a DWORD with this value when it couldn't determine the file's attributes. In the Python codebase, there are basically three values this is compared with, the above macro, 0x and (DWORD)-1, it should only be the macro.