[issue4814] ftplib does not honour "timeout" parameter for active data connections

Giampaolo Rodola' added the comment: Fixed as r80226 (2.7) and r80228 (3.2). -- components: +Library (Lib) priority: -> normal resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Changes by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mail

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Giampaolo Rodola' added the comment: This time it's not easy as I see no way to distinguish whether the timeout exception gets raised by the command or the control socket, as makeport() method implementation deals with both: host = self.sock.getsockname()[0] if self.af == so

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Antoine Pitrou added the comment: This looks good, of course. Perhaps you want to add a test, if it isn't too difficult to do so. -- versions: +Python 3.2 -Python 3.0 ___ Python tracker

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Changes by Giampaolo Rodola' : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Changes by STINNER Victor : Removed file: http://bugs.python.org/file12552/ftplib.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue4814] ftplib does not honour "timeout" parameter for active data connections

Giampaolo Rodola' added the comment: I'm sorry, I realized right now that settimeout() should be used also *before* invoking accept(), to avoid the client to stall in case the server does not establish any connection. The second patch in attachment does that by using settimeout() straight into F

[issue4814] ftplib does not honour "timeout" parameter for active data connections

STINNER Victor added the comment: Your patch looks correct. -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue4814] ftplib does not honour "timeout" parameter for active data connections

New submission from Giampaolo Rodola' : When using the optional ftplib.FTP()'s timeout parameter which specifies a timeout in seconds for blocking operations like the connection attempt, it is applied on both FTP control and passive data channel (if any). It is not applied for active (PORT/EPR