[issue4772] undesired switch fall-through in socketmodule.c

Antoine Pitrou added the comment: Committed in all four branches, thank you. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue4772] undesired switch fall-through in socketmodule.c

Changes by Brian Curtin : Added file: http://bugs.python.org/file16090/issue4772.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4772] undesired switch fall-through in socketmodule.c

Changes by Brian Curtin : Removed file: http://bugs.python.org/file16089/issue4772.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue4772] undesired switch fall-through in socketmodule.c

Brian Curtin added the comment: Minor change to the patch to correct for Antoine's suggestion. -- Added file: http://bugs.python.org/file16089/issue4772.diff ___ Python tracker _

[issue4772] undesired switch fall-through in socketmodule.c

Changes by Brian Curtin : Removed file: http://bugs.python.org/file15665/issue4772.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue4772] undesired switch fall-through in socketmodule.c

Antoine Pitrou added the comment: "makesockaddr" shouldn't be mentioned in the exception message, since it's just an internal helper function. -- nosy: +pitrou ___ Python tracker __

[issue4772] undesired switch fall-through in socketmodule.c

Changes by Brian Curtin : -- priority: -> normal type: -> behavior versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0 ___ Python tracker ___ _

[issue4772] undesired switch fall-through in socketmodule.c

Brian Curtin added the comment: I think both AF_BLUETOOTH and AF_TIPC should raise ValueError since the type of the argument is correct but it's not a good value. I piggybacked on Amaury's patch and changed the exceptions with a patch against r77004. -- nosy: +brian.curtin Added file: h

[issue4772] undesired switch fall-through in socketmodule.c

STINNER Victor added the comment: makesockaddr() raise a TypeError("Invalid address type") for an invalid AF_TIPC address, but I would prefer a ValueError. -- nosy: +haypo ___ Python tracker __

[issue4772] undesired switch fall-through in socketmodule.c

Georg Brandl added the comment: TypeError or ValueError? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue4772] undesired switch fall-through in socketmodule.c

Amaury Forgeot d'Arc added the comment: See attached patch. -- keywords: +needs review, patch nosy: +amaury.forgeotdarc stage: -> patch review versions: +Python 2.6, Python 3.0 Added file: http://bugs.python.org/file12507/bluetooth.patch ___ Python

[issue4772] undesired switch fall-through in socketmodule.c

New submission from dontbugme : makesockaddr() in socketmodule.c will fall through from AF_BLUETOOTH to AF_PACKET if none of Bluetooth protocols match. That's not a very appropriate thing to do. -- messages: 78483 nosy: dontbugme severity: normal status: open title: undesired switch fall