[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Martin v. Löwis added the comment: Committed as r68885, r68886, r68887, and r6 -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Changes by Martin v. Löwis : Added file: http://bugs.python.org/file12605/zipdir.zip ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Martin v. Löwis added the comment: Here is a version of the patch that rationalizes usage of os.sep, fixes a few bugs with r2, and adds a test case. -- keywords: +needs review nosy: +loewis Added file: http://bugs.python.org/file12604/dir.diff ___ Py

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Changes by Martin v. Löwis : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Gabriel Genellina added the comment: Your usage of os.sep is incorrect, both when reading and writing directories. Zip files are (more-or-less) platform independent. The specification *requires* forward slashes in paths [1], and the zipfile module already writes them that way. Checking for o

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Changes by Kuba Wieczorek : Removed file: http://bugs.python.org/file12420/zipfile_extract_dirs_r2.patch ___ Python tracker ___ ___ Python-bugs

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Changes by Kuba Wieczorek : Added file: http://bugs.python.org/file12435/zipfile_dirs_support.patch ___ Python tracker ___ ___ Python-bugs-list

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Changes by Kuba Wieczorek : Removed file: http://bugs.python.org/file12433/zipfile_dirs_support.patch ___ Python tracker ___ ___ Python-bugs-li

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Kuba Wieczorek added the comment: Here is a revised version of the patch with directories support for write(). It works like UNIX zip program so if a directory path is passed to the function, it stores only the directory itself (without the contents). This time without tests as well because I d

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Kuba Wieczorek added the comment: I'm not sure if it would make sense to save current extract()/extractall() behaviour and implement new with another function because current one is simply faulty. And if it's about BC breaks then well... it may be introduced in 3.0 line, I think that leaving fau

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

Koen van de Sande added the comment: I'm no expert, but is it possible for ZIP files to have Windows-style path seperators ('\') as well? And is this new behavior desirable for existing code as well? It might break existing applications, so perhaps a new extractrecursive() function is more in

[issue4710] [PATCH] zipfile.ZipFile does not extract directories properly

New submission from Kuba Wieczorek : This behaviour has been known of course for quite long time. I suppose this is not intentional so I've played a bit with this and I hope you'll consider some little change. Currently, if a ZIP archive contains some subdirectories then zipfile.ZipFile.extract(