[issue45375] Windows assertion in out-of-tree debug build

Steve Dower added the comment: New changeset 6c942a86a4fb4c8b731cb1bd2933dba554eb79cd by Steve Dower in branch 'main': bpo-45375: Fix off by one error in buffer allocation (GH-28764) https://github.com/python/cpython/commit/6c942a86a4fb4c8b731cb1bd2933dba554eb79cd -- __

[issue45375] Windows assertion in out-of-tree debug build

Change by Steve Dower : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailin

[issue45375] Windows assertion in out-of-tree debug build

Change by Steve Dower : -- pull_requests: +27104 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/28764 ___ Python tracker ___ _

[issue45375] Windows assertion in out-of-tree debug build

Steve Dower added the comment: Thanks for mentioning it! New PR to fix -- priority: release blocker -> high ___ Python tracker ___

[issue45375] Windows assertion in out-of-tree debug build

Eryk Sun added the comment: I left a message on the PR a day ago about a one-off error in the allocation of `buff`. The size should be `MAXPATHLEN + 1`. That's what's used everywhere else in PC/getpathp.c and what gets passed in the PathCchCombineEx(buff, MAXPATHLEN + 1, ...) call.

[issue45375] Windows assertion in out-of-tree debug build

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue45375] Windows assertion in out-of-tree debug build

Steve Dower added the comment: New changeset 5146877623ebe8a2806411703b0de9c0aba179a1 by Steve Dower in branch 'main': bpo-45375: Fix assertion failure due to searching for stdlib in unnormalised paths (GH-28735) https://github.com/python/cpython/commit/5146877623ebe8a2806411703b0de9c0aba179

[issue45375] Windows assertion in out-of-tree debug build

Change by Steve Dower : -- keywords: +patch pull_requests: +27083 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28735 ___ Python tracker ___

[issue45375] Windows assertion in out-of-tree debug build

Steve Dower added the comment: I believe this is because getpath has hit its final fallback case of looking in ".\DLLs" and ".\Lib" for the standard library, and has not performed proper normalisation on these paths. So after removing the last segment, the result is "." which does not end in

[issue45375] Windows assertion in out-of-tree debug build

New submission from Steve Dower : As seen in the release build for 3.11a1, an assertion is raised when attempting to launch the debug build out of tree. _RegenTestFrozenmain: Regenerate test_frozenmain.h D:\a\1\b\bin\amd64\python_d.exe Programs\freeze_test_frozenmain.p