[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: New changeset 54a1760cde7bb01e5574734c389c0746762218fd by Serhiy Storchaka in branch 'main': bpo-45212: Add a comment for time.sleep() in tests (GH-28414) https://github.com/python/cpython/commit/54a1760cde7bb01e5574734c389c0746762218fd -- __

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: I have merged the backported PRs because they are blockers for my other PR which is a blocker for my other PR which is a blocker for my other PR and several future PRs. -- ___ Python tracker

[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- pull_requests: +26826 pull_request: https://github.com/python/cpython/pull/28414 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

Łukasz Langa added the comment: Haha, which you just did. Cool. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: New changeset 10c3cf78518f4b31e1527c2795694b1bcb092696 by Serhiy Storchaka in branch '3.9': [3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28408) https://github.com/python/cpython/commit/10c3cf78518f4b31e1527c2795694b1

[issue45212] Dangling threads in skipped tests in test_socket

Łukasz Langa added the comment: We can add a comment to the effect that "the wait here needs to be longer than the client-side (0.01s)". Since you already merged the change to `main`, it will be easiest to merge the backports as well and add the comment in a follow-up series. -- nosy

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: New changeset ce59ac93626004894c2b291ec599a36cfa9fb0be by Serhiy Storchaka in branch '3.10': [3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28409) https://github.com/python/cpython/commit/ce59ac93626004894c2b291ec599a

[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- pull_requests: +26821 pull_request: https://github.com/python/cpython/pull/28409 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- pull_requests: +26820 pull_request: https://github.com/python/cpython/pull/28408 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: Yes, it is a deliberate choice. It is difficult to explain why it was passed without it -- dues to a specific order of calling tearDown() and callbacks registered with addCleanup() in different base classes. Using an event object would fix it too, but: *

[issue45212] Dangling threads in skipped tests in test_socket

STINNER Victor added the comment: def testWithTimeoutTriggeredSend(self): conn = self.accept_conn() conn.recv(88192) +time.sleep(1) Was it a deliberate choice to add a sleep of 1 second? If yes, can you please add a comment to explain why? -- nosy: +vstinner

[issue45212] Dangling threads in skipped tests in test_socket

Change by miss-islington : -- pull_requests: +26799 pull_request: https://github.com/python/cpython/pull/28385 ___ Python tracker ___ __

[issue45212] Dangling threads in skipped tests in test_socket

Serhiy Storchaka added the comment: New changeset 7dacb70485a0910eb298c24b4d051720ca56fb91 by Serhiy Storchaka in branch 'main': bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) https://github.com/python/cpython/commit/7dacb70485a0910eb298c24b4d051720ca56fb91 -

[issue45212] Dangling threads in skipped tests in test_socket

Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +26798 pull_request: https://github.com/python/cpython/pull/28384 ___ Python tracker _

[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- pull_requests: +26789 pull_request: https://github.com/python/cpython/pull/28317 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26775 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28361 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

New submission from Serhiy Storchaka : Dangling threads are reported when run test_socket tests which raise SkipTest in setUp() in refleak mode. $ ./python -m test -R 3:3 test_socket -m testBCM 0:00:00 load avg: 2.53 Run tests sequentially 0:00:00 load avg: 2.53 [1/1] test_socket beginning 6 r