Re: [issue4496] misleading comment in urllib2

On Thu, Dec 23, 2010 at 07:53:01PM +, R. David Murray wrote: > The sorting is based on a 'handler_order' attribute, by the way, and > presumably does control the order in which they are applied. Yes. Exactly. ___ Python-bugs-list mailing list Unsubs

[issue4496] misleading comment in urllib2

R. David Murray added the comment: It is used in the tests, but I agree that it doesn't appear to be used in the code. I've removed the misleading comment and marked the self.handlers attribute as backward-compat-only in r87448, r87449, and r87450. The sorting is based on a 'handler_order' a

[issue4496] misleading comment in urllib2

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: (The change was actually r54138) It seems that this .handlers attribute was used in older versions, before r34922, to close the handlers in-order. IMO it is no more useful, but may be kept for compatibility reasons. -- nosy: +a

[issue4496] misleading comment in urllib2

Changes by John J Lee <[EMAIL PROTECTED]>: -- components: +Library (Lib) nosy: +facundobatista versions: +Python 2.7, Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4496] misleading comment in urllib2

New submission from John J Lee <[EMAIL PROTECTED]>: r54137 replaced a comment in urllib2.py with a misleading comment. The comment now implies the .insort() in question achieves the goal specified in the new comment. That's not true, which was the reason the original comment was there in the fi