[issue44789] Code compliance concern in Parser/pegen/pegen.c

Pablo Galindo Salgado added the comment: I'm removing the parser component, as this is a general problem (the only reason you see the parser is because with -Werror that is reported first). -- ___ Python tracker

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Pablo Galindo Salgado added the comment: For example, if I remove -Werror, you will get tons of warnings that will eventually become errors even if the parser code is "fixed": ./Modules/posixmodule.c:13781:18: note: (near initialization for ‘DirEntryType_slots[1].pfunc’) ./Modules/posixmodule

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Pablo Galindo Salgado added the comment: You cannot compile CPython with `-pedantic`. For example, if i add that to my collection of CFLAGS with gcc 11, many object files do not compile (too many to report here). That is not a supported compilation flag and certainly this problem is not only

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Dennis Clarke added the comment: Minor note. I am going to change the component to the Parser. -- components: +Parser -C API ___ Python tracker ___ ___

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Dennis Clarke added the comment: This was an excellent opportunity to review these CFLAGS and to ponder the value of each. This took me a day to write and was then reviewed by a team. I hope it answers your question. --- There is noth

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Pablo Galindo Salgado added the comment: Seems to me that you are not only running configure + make but you are adding things to the CFLAGS. Could you please add a list of all the extra complication flags you are adding? -- ___ Python tracker

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Dennis Clarke added the comment: Let me see if I can be a bit more clear with the problem that I am seeing on three separate systems. It does seem to be an issue in a macro : 1) Debian Linux on IBM Power ppc64 big-endian : enceladus$ uname -a Linux enceladus 5.13.4-genunix #1 SMP Tue Jul 2

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Pablo Galindo Salgado added the comment: Dennis Clarke, thanks for the report. Unfortunately we don't know how to reproduce the problems you mention. Could you please indicate what are you running? For instance, I can compile with 11.1.0 with absolutely no problems here. -- ___

[issue44789] Code compliance concern in Parser/pegen/pegen.c

Dennis Sweeney added the comment: To be specific, is this about the fact that .arg is a member of `struct _arg` (typedef'ed as `arg_ty`), while at the same time arg() is a macro? as in: https://github.com/python/cpython/blob/0f42b726c87f72d522893f927b4cb592b8875641/Parser/pegen/pegen.c#L37

[issue44789] Code compliance concern in Parser/pegen/pegen.c

New submission from Dennis Clarke : With release 3.9.6 I see failures in compile on three system architectures and with three compilers. I did check with GCC 10.2.1 ( Debian 10.2.1-6 ) on IBM Power and also with FreeBSD UNIX LLVM/Clang 12.0.1 on AMD64 and also with Oracle Studio C99 strict in So