[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Jesse Noller : -- resolution: accepted -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller added the comment: Checked into trunk in r68708 - I pinged benjamin to see how we're handling merges right now as this needs to go into py3k -- status: open -> closed ___ Python tracker __

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller added the comment: FYI, there was a small issue in the patch - namely the only way to get the AttributeError to raise in the Value/Array creation is to not pass in a lock, True/None - the latter two get to a lock/RLock while the former will have the acquire method. If you pass i

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Jesse Noller : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-b

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller added the comment: FYI, there was a small issue in the patch - namely the only way to get the AttributeError to raise in the Value/Array creation is to not pass in a lock, True/None or False - the latter three get to a lock/RLock while the former will have the acquire method. I c

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller added the comment: I agree with Martin - if no one else gets to this before me, I should be able to submit it within the next day. ___ Python tracker ___ ___

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Martin v. Löwis added the comment: I think Amaury's patch (mp_array_2.patch) is correct. If there is no objection to its acceptance within the next two days, I think it should be applied. -- resolution: -> accepted ___ Python tracker

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Amaury Forgeot d'Arc : -- keywords: +needs review stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Martin v. Löwis : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- priority: release blocker -> deferred blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: deferred blocker -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: What about this other patch: - lock=None has the same semantics as before - lock=True is the same as lock=None (it failed before) - lock=False return the object without the "synchronized" wrap (it failed before) - no need to change prev

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: I've changed my mind based on the API change. This should be discussed on the mailing list and deferred until 2.6.2 at least. -- resolution: accepted -> ___ Python tracker <[EMAIL PROTECTED]>

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: The one I know is pypy: bool(x) always return one of the two prebuilt singletons (doubletons?). The docs explicitly mention "If lock is True...", "If lock is False...": http://docs.python.org/library/multiprocessing.html#multiprocessi

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: Does the language guarantee that True and False are singletons (to support the is-test for identity)? Does this API port to Jython and IronPython? Is it a problem that 1 cannot be substituted for True? -- nosy: +rhettinger _

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Indeed, it seems that multiprocessing uses assertions in many places to handle errors in user code. This could be changed, but it is another task. I can apply the patch, but what about 2.6? it's an incompatible API change, unless we

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: I don't much like the lock is True lock is False idioms much, but I don' thave a better suggestion, and it would be nice to fix this for the releases. -- resolution: -> accepted ___ Python trac

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: +1 on Amaury's patch, however I wouldn't change the assert right now - Christian's suggestion does make sense to change globally post 3.0 Amaury, do you want to submit it? ___ Python tracker <[EMAIL PROTECT

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Christian Heimes <[EMAIL PROTECTED]> added the comment: The patch looks fine. However I propose to replace the assert statement with a proper check that raises a meaningful exception. if not hasattr(lock, 'acquire'): raise AttributeError("'%r' has no method 'acquire'" % lock) __

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Here is a patch nonetheless. It makes the code match the the documentation: http://docs.python.org/library/multiprocessing.html#multiprocessing.sharedctypes.Arra y """ - If lock is True (the default) then a new lock object is created to

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: 2.6.0 shipped with the assertion error. Unfortunately, I'm tapped out at the day job right now, so I won't have a fix prepped and tested in time. -- priority: release blocker -> deferred blocker ___

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Jesse, does this affect Python 3.0? If not, then I will lower the priority and release 2.6.1 without it (there's always 2.6.2 :). If so, then we need to know if 1) it's really a release blocker; 2) what the ETA on a fix is. I would like to

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: This is not a doc bug - in actuality, the mp_benchmarks.py example is exposing an assertion error in sharedctypes.py. The doc-related bugs Christian and I spoke about have been fixed, however the main issue for this (the assertion error) is s

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: This is a documentation bug, not a library bug, right? (unless someone claims that the documentation is right and the library is wrong) So: a) this seems to be a duplicate of issue 3256, and b) it's "just" a documention bug. Not sure why thi

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Jesse, please apply so we can close this issue. -- nosy: +barry ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: I guess you just 2to3'ed the examples ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-b

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: Yes, I have a pending patch. I'll see if I can steal some time today to check it in. On Fri, Nov 28, 2008 at 9:36 AM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > Christian Heimes <[EMAIL PROTECTED]> added the comment: > > Are you able to fi

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Christian Heimes <[EMAIL PROTECTED]> added the comment: Are you able to fix the examples before 3.0.0 and 2.6.1 are released? They are scheduled for Wednesday 3rd of December. ___ Python tracker <[EMAIL PROTECTED]> __

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Jesse Noller <[EMAIL PROTECTED]> added the comment: The 3.0 doc/example issue is in issue 3256 I plan on fixing all the doc/example issue this/next week. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

Christian Heimes <[EMAIL PROTECTED]> added the comment: The examples in 3.0 didn't work at at all because nobody did a 2to3 run on them. See r67417: mp_benchmarks, mp_newtypes and mp_distribution are still broken but the others are working properly. We should include the examples in our unit test

[issue4449] AssertionError in Doc/includes/mp_benchmarks.py

New submission from Christian Heimes <[EMAIL PROTECTED]>: ./python Doc/includes/mp_benchmarks.py testing Array("i", ..., lock=False) Traceback (most recent call last): File "Doc/includes/mp_benchmarks.py", line 235, in test() File "Doc/includes/mp_benchmarks.py", line 2