[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: New changeset 317e9ed4363a86b1364573c5a5e30011a080ce6d by Miss Islington (bot) in branch '3.10': bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held (GH-26551) (GH_26552) https://github.com/python/cpython/commit/317e9e

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by miss-islington : -- pull_requests: +25139 pull_request: https://github.com/python/cpython/pull/26552 ___ Python tracker ___ __

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: New changeset 6e3b7cf3af3ed7758b2c2193c1d393feb8ab8f72 by Pablo Galindo in branch 'main': bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held (GH-26551) https://github.com/python/cpython/commit/6e3b7cf3af3ed7758b2c2193

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Pablo Galindo Salgado : -- pull_requests: +25138 pull_request: https://github.com/python/cpython/pull/26551 ___ Python tracker ___ ___

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: > sqlit3.Cursor is prone to the same bug. No, is not: it doesn't drop the GIL in tp_clear. There is technically no bug, but is true that tp_clear should only clean Python references. Although in this case there are some sematics with the cleanup that

[issue44304] segmentation fault appeared in python 3.10.0b2

Erlend E. Aasland added the comment: sqlit3.Cursor is prone to the same bug. Do you want me to create a new issue for it, or can I reuse this issue number, Pablo? I'll see if I can create a reproducer for that as well. -- ___ Python tracker

[issue44304] segmentation fault appeared in python 3.10.0b2

mike bayer added the comment: great news! Based on how many random factors were needed to reproduce as well as that it seemed to be gc related and appeared very suddenly, I had an intuition this was on the cpython side, thanks so much for doing this Pablo! -- ___

[issue44304] segmentation fault appeared in python 3.10.0b2

Erlend E. Aasland added the comment: Thanks Mike for the report and reproducer, and Pablo for the fix! -- ___ Python tracker ___ __

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44304] segmentation fault appeared in python 3.10.0b2

miss-islington added the comment: New changeset ad2f3b74b5615aa36a82d1fdbc45bb7468aa1d72 by Miss Islington (bot) in branch '3.10': bpo-44304: Fix crash in the sqlite3 module when the GC clears Statement objects (GH-26545) https://github.com/python/cpython/commit/ad2f3b74b5615aa36a82d1fdbc45b

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: New changeset fa106a685c1f199aca5be5c2d0277a14cc9057bd by Pablo Galindo in branch 'main': bpo-44304: Fix crash in the sqlite3 module when the GC clears Statement objects (GH-26545) https://github.com/python/cpython/commit/fa106a685c1f199aca5be5c2d0277

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +25136 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26547 ___ Python tracker _

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: This is a simpler reproducer: dest = sqlite.connect(':memory:') def md5sum(t): return dest.create_function("md5", 1, md5sum) x = dest("create table lang (name, first_appeared)") del md5sum, dest

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: Using the reproducer code by Mike, without this fix: ❯ ./python ../lel.py [1]25344 segmentation fault ./python ../lel.py With this fix: ❯ ./python ../problem.py ❯ echo $? 0 -- ___ Python tracker

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: The problem is that this is wrong: https://github.com/python/cpython/blob/f171877ebe276749f31386baed5841ce37cbee2e/Modules/_sqlite/statement.c#L411-L423 1) tp_clear should *not* do anything other than cleaning refs to python objects 2) sqlite3_finalize

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +25135 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26545 ___ Python tracker __

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Pablo Galindo Salgado : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Pablo Galindo Salgado : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue44304] segmentation fault appeared in python 3.10.0b2

Pablo Galindo Salgado added the comment: I did the bisection: ff359d735f1a60878975d1c5751bfd2361e84067 is the first bad commit commit ff359d735f1a60878975d1c5751bfd2361e84067 Author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com> Date: Mon May 31 02:12:27 2021 -0700

[issue44304] segmentation fault appeared in python 3.10.0b2

Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue44304] segmentation fault appeared in python 3.10.0b2

mike bayer added the comment: yes, if I have time I will begin to undertake that, wanted to put it up here in case anyone has git bisect on speed dial for cpython. -- ___ Python tracker

[issue44304] segmentation fault appeared in python 3.10.0b2

Terry J. Reedy added the comment: Coredevs are likely to assume that the problem is in greenlets, especially if it has any C code (I don't know). I suggest you first try to find the commit between releases that resulted in the problem. If it is not deterministicly reproducible, you likely

[issue44304] segmentation fault appeared in python 3.10.0b2

mike bayer added the comment: if the issue is in greenlet this can be bounced back to https://github.com/python-greenlet/greenlet/issues/242 -- ___ Python tracker ___ ___

[issue44304] segmentation fault appeared in python 3.10.0b2

New submission from mike bayer : segmentation fault related to object deallocation and traceback objects, is extremely difficult to reproduce and definitely appeared as of 3.10.0b2, does not occur in 3.10.0b1. linux and osx platforms are affected. The issue requires "greenlet==1.1.0" to be