[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailin

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread miss-islington
miss-islington added the comment: New changeset 6143fcdf8bfe54c24e3081bcee423f4d51f35c4e by Dong-hee Na in branch 'master': bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl (GH-25756) https://github.com/python/cpython/commit/6143fcdf8bfe54c24e3081bcee423f4d51f35c4e --

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Dong-hee Na added the comment: > I don't mind if you reopen your PR. But thanks for asking. I add your name as the co-author on PR 25756 :) Thanks for the report and suggestion -- ___ Python tracker ___

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +24449 pull_request: https://github.com/python/cpython/pull/25756 ___ Python tracker ___ _

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Christoph Zwerschke
Christoph Zwerschke added the comment: I don't mind if you reopen your PR. But thanks for asking. -- ___ Python tracker ___ ___ Pyt

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- versions: -Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Dong-hee Na added the comment: > I saw you submitted a PR already which looks good to me. I should care that you can have a chance to submit the patch :) Is it okay to proceed with this issue with the PR which I closed or do you want to open a PR with your hand? -- _

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Christoph Zwerschke
Christoph Zwerschke added the comment: I saw you submitted a PR already which looks good to me. -- ___ Python tracker ___ ___ Pytho

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Dong-hee Na added the comment: > I can provide a PR if wanted. Please submit the PR if you want -- ___ Python tracker ___ ___ Pyth

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: -24446 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue43979] Simplify urllib.parse_qsl

2021-04-30 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +patch nosy: +corona10 nosy_count: 2.0 -> 3.0 pull_requests: +24446 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25756 ___ Python tracker _

[issue43979] Simplify urllib.parse_qsl

2021-04-29 Thread robertohueso
robertohueso added the comment: Seems like a nice simplification to me. Can I open PR? :) -- nosy: +robertohueso ___ Python tracker ___ ___

[issue43979] Simplify urllib.parse_qsl

2021-04-29 Thread Christoph Zwerschke
New submission from Christoph Zwerschke : Just noticed the following code in urrlib.parse_qsl: pairs = [s1 for s1 in qs.split(separator)] for name_value in pairs: ... see https://github.com/python/cpython/blob/088a15c49d99ecb4c3bef93f8f40dd513c6cae3b/Lib/urllib/parse.py#L755