[issue43851] Optimise SQLite builds on macOS and Windows

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43851] Optimise SQLite builds on macOS and Windows

Steve Dower added the comment: New changeset 8702b667d8e7da7a1888297d84f493f26c580a2d by Erlend Egeberg Aasland in branch 'main': bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows (GH-25414) https://github.com/python/cpython/commit/8702b667d8e7da7a1888297d84f493f26c580a2d ---

[issue43851] Optimise SQLite builds on macOS and Windows

Ned Deily added the comment: New changeset 555cbbe7c10c29ec4358c66c247b8d7e871a5f7b by Erlend Egeberg Aasland in branch 'master': bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on macOS (GH-25413) https://github.com/python/cpython/commit/555cbbe7c10c29ec4358c66c247b8d7e871a5f7b -

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: If Berker does not disapprove, I'd like to apply GH-25413 and GH-25414 to the installers, Steve & Ned. -- ___ Python tracker ___ ___

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: Oh, well, SQLITE_DEFAULT_MEMSTATUS=0 does in fact affect PRAGMA soft_heap_limit. Looks like I'm left with only SQLITE_OMIT_AUTOINIT, then :) -- ___ Python tracker _

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: Here's a list of the SQLite recommended compile-time options (only): - macOS (v11.2.3) (SQLite v3.32.3) defines SQLITE_DEFAULT_WAL_SYNCHRONOUS=1 - Homebrew (SQLite v3.35.4) does not define any of the recommended compile-time options - Debian Buster (S

[issue43851] Optimise SQLite builds on macOS and Windows

Berker Peksag added the comment: As long as we don't introduce behavior changes between SQLite versions in mainstream Linux distributions and macOS/Windows (i.e. an application should continue working in Linux, macOS, Windows), it sounds good to me. Maybe it's worth checking what compile opt

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: As noted in https://github.com/python/cpython/pull/25414#issuecomment-828501078, SQLITE_OMIT_DEPRECATED also leaves out PRAGMA's, which can break applications. I'll update the PR's to leave it out. -- ___

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: I suggest applying the following safe options for the installers: # SQLITE_DEFAULT_MEMSTATUS Memory status is currently not available in the sqlite3 API, so there's no need for SQLite to keep track of this. If we add such an API (not likely, IMO), we

[issue43851] Optimise SQLite builds on macOS and Windows

Change by Erlend Egeberg Aasland : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue43851] Optimise SQLite builds on macOS and Windows

Change by Erlend Egeberg Aasland : -- pull_requests: +24146 pull_request: https://github.com/python/cpython/pull/25414 ___ Python tracker ___ __

[issue43851] Optimise SQLite builds on macOS and Windows

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +24145 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25413 ___ Python tracker _

[issue43851] Optimise SQLite builds on macOS and Windows

Erlend Egeberg Aasland added the comment: BTW, is SQLITE_WITHOUT_ZONEMALLOC still needed for macOS? -- ___ Python tracker ___ ___ P

[issue43851] Optimise SQLite builds on macOS and Windows

New submission from Erlend Egeberg Aasland : We should apply some of the recommended "optimisation" compile-time options[1] to the SQLite builds for the macOS and Windows installers. The following options should be safe to apply: - SQLITE_DEFAULT_MEMSTATUS=0 - SQLITE_LIKE_DOESNT_MATCH_BLOBS -