[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

Change by Dong-hee Na : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

miss-islington added the comment: New changeset 5486b105a4c5de840c24776c726eeac2a8dc973c by Miss Islington (bot) in branch '3.8': bpo-43637: Fix a possible memory leak in winreg.SetValueEx() (GH-25038) https://github.com/python/cpython/commit/5486b105a4c5de840c24776c726eeac2a8dc973c ---

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

miss-islington added the comment: New changeset f79577ddbd7c87b6cc1810e98ee4eaca7ae50699 by Miss Islington (bot) in branch '3.9': bpo-43637: Fix a possible memory leak in winreg.SetValueEx() (GH-25038) https://github.com/python/cpython/commit/f79577ddbd7c87b6cc1810e98ee4eaca7ae50699 ---

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

Change by miss-islington : -- pull_requests: +23839 pull_request: https://github.com/python/cpython/pull/25094 ___ Python tracker ___ __

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

Dong-hee Na added the comment: New changeset dfeec347f21b86879ba8f27f567bb275b243f1bc by Zackery Spytz in branch 'master': bpo-43637: Fix a possible memory leak in winreg.SetValueEx() (GH-25038) https://github.com/python/cpython/commit/dfeec347f21b86879ba8f27f567bb275b243f1bc -- nos

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +23838 pull_request: https://github.com/python/cpython/pull/25093 ___ Python tracker _

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 5.0 -> 6.0 pull_requests: +23786 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25038 ___ Python tracker

[issue43637] winreg: SetValueEx leaks memory if PySys_Audit fails

New submission from Ondrej Baranovič : The function `winreg_SetValueEx_impl` in `winreg.c`: 1) Allocates memory by calling `Py2Reg`, 2) calls `PySys_Audit` and immediately returns if it indicates an error, 3) calls `RegSetValueExW`, 4) frees memory allocated in (1) and returns. The if-block in