[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue43636] test_descr fails randomly when executed with -R :

Dino Viehland added the comment: @vstinner - The fix doesn't change the behavior of _PyType_Lookup and instead just fixes a previous unrelated bug. The condition will typically ever be hit once (at startup) as it's very unlikely that versions will wrap, so there should be no performance dif

[issue43636] test_descr fails randomly when executed with -R :

STINNER Victor added the comment: Is _PyType_Lookup() still faster after the fix? The optimization is mentioned at: https://docs.python.org/dev/whatsnew/3.10.html#optimizations -- ___ Python tracker ___

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: New changeset 11b85abbae8aaa8410b19f358abd7b401881bb1c by Pablo Galindo in branch 'master': bpo-43636: Validate the version tag in _PyType_Lookup (GH-25032) https://github.com/python/cpython/commit/11b85abbae8aaa8410b19f358abd7b401881bb1c --

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Yup, that makes sense. Let me update the PR -- ___ Python tracker ___ ___ Python-bugs-list

[issue43636] test_descr fails randomly when executed with -R :

Dino Viehland added the comment: I think the issue here is that in assign_version_tag there's this code: if (type->tp_version_tag == 0) { // Wrap-around or just starting Python - clear the whole cache type_cache_clear(cache, 1); return 1; } the return 1 is inco

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: I think I have it, we still neet to validate that the version tag is correct. Can you take a look at https://github.com/python/cpython/pull/25032 ? -- stage: patch review -> ___ Python tracker

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23780 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25032 ___ Python tracker __

[issue43636] test_descr fails randomly when executed with -R :

Dino Viehland added the comment: And it looks like we have an entry with a 0 version, but with a valid name: (type_cache_entry) $3 = { version = 0 name = 0x000100ec44f0 value = NULL } -- ___ Python tracker

[issue43636] test_descr fails randomly when executed with -R :

Dino Viehland added the comment: It's probably worth having an assert that the version tag is valid, that'll make it easier to see what's going wrong in the cache hit case. We should have the version tag being 0 now when it's not valid. I may not be able to debug it anymore tonight, but if

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Seems that the problem is removing the check: if (MCACHE_CACHEABLE_NAME(name) && _PyType_HasFeature(type, Py_TPFLAGS_VALID_VERSION_TAG)) { -- ___ Python tracker

[issue43636] test_descr fails randomly when executed with -R :

Dino Viehland added the comment: Looking! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Dino, could you take a look? -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Bisecting points at: commit ee48c7d54147ae906776b9f6f96e8920e097d0c4 Author: Dino Viehland Date: Sat Mar 20 12:12:05 2021 -0700 bpo-43452: Micro-optimizations to PyType_Lookup (GH-24804) The common case going through _PyType_Lookup is to ha

[issue43636] test_descr fails randomly when executed with -R :

New submission from Pablo Galindo Salgado : ❯ ./python -m test test_descr -m test_slots -R 3:3 0:00:00 load avg: 0.26 Run tests sequentially 0:00:00 load avg: 0.26 [1/1] test_descr beginning 6 repetitions 123456 test test_descr failed -- Traceback (most recent call last): File "/home/pablogsal/