[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Fred Drake
Fred Drake added the comment: PR applied and backported; closing this. Thanks, Jared! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Fred Drake
Fred Drake added the comment: New changeset 455583b54aaec9a4266ff37dd438cbbd8ec6068a by Miss Islington (bot) in branch '3.8': bpo-43620: Remove reference to os.sep from os.path.join() doc (GH-25025, GH-5030) https://github.com/python/cpython/commit/455583b54aaec9a4266ff37dd438cbbd8ec6068a

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +23779 pull_request: https://github.com/python/cpython/pull/25030 ___ Python tracker ___ __

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Fred Drake
Fred Drake added the comment: New changeset f311290f091957653bba5ebfda28ad981bb78363 by Miss Islington (bot) in branch '3.9': bpo-43620: Remove reference to os.sep from os.path.join() doc (GH-25025) (#25027) https://github.com/python/cpython/commit/f311290f091957653bba5ebfda28ad981bb78363

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +23777 pull_request: https://github.com/python/cpython/pull/25027 ___ Python tracker _

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Fred Drake
Fred Drake added the comment: New changeset 21a2cabb3795f5170c746ab8f29e9d25c7442550 by Jared Sutton in branch 'master': bpo-43620: Remove reference to os.sep from os.path.join() doc (#25025) https://github.com/python/cpython/commit/21a2cabb3795f5170c746ab8f29e9d25c7442550 -- _

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Jared Sutton
Jared Sutton added the comment: Thank you for understanding my position, Fred. I submitted a draft PR (25025) for this bug. -- ___ Python tracker ___

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-26 Thread Jared Sutton
Change by Jared Sutton : -- keywords: +patch pull_requests: +23775 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/25025 ___ Python tracker

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Fred Drake
Fred Drake added the comment: Just reviewed the documentation for both os.sep and os.path.join(). The os.sep docs do not suggest it can be set, and the reference in the os.path.join() description is silent regarding that, so can be read as Jared did. I don't recall this coming up before, bu

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Jared Sutton
Jared Sutton added the comment: > Perhaps Jared was expecting that modifying os.sep would affect the functions > in os.path? This is precisely what I thought, because the documentation makes it sound like that variable named os.sep is read and used as the path delimiter when constructing so

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Eryk Sun
Eryk Sun added the comment: Fred, do you think this needs to be reopened to clarify that os.sep and os.altsep are not parameters for the ntpath and posixpath modules? I would have thought that the note at the top (path name conventions, etc) would be sufficient to let someone know that os.p

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Fred Drake
Fred Drake added the comment: Perhaps Jared was expecting that modifying os.sep would affect the functions in os.path? os.sep was never intended to be updated. Using the specific *path modules to work with "foreign" paths has long been advocated as the way to do this. It isn't a work-aroun

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Eryk Sun
Eryk Sun added the comment: > certainly you can see this is a doc bug, since the doc clearly > states that os.sep is utilized to join the elements of the path, > when it clearly isn't; right? os.path is ntpath in Windows, which uses backslash as the path separator, which is the same as os.se

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-25 Thread Jared Sutton
Jared Sutton added the comment: I can understand your suggestion to just utilize the posixpath library on Windows if needed. That's a reasonable work-around. But certainly you can see this is a doc bug, since the doc clearly states that os.sep is utilized to join the elements of the path, wh

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-24 Thread Eryk Sun
Eryk Sun added the comment: The documentation of os.path.join() uses os.sep because it's written from the perspective of the platform's os.path, which is posixpath on a POSIX system and ntpath on a Windows system. If you need to work with POSIX paths in Windows, then use posixpath. It will o

[issue43620] os.path.join does not use os.sep as documentation claims

2021-03-24 Thread Jared Sutton
New submission from Jared Sutton : The behavior of os.path.join() does not match the documentation, in regards to the use of os.sep. From the docs: """ The return value is the concatenation of path and any members of *paths with exactly one directory separator (os.sep) following each non-emp