[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Łukasz Langa added the comment: Thanks all for your effort on improving this! ✨ 🍰 ✨ -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11,

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Łukasz Langa added the comment: New changeset 7dad0337518a0d599caf8f803a5bf45db67cbe9b by Miss Islington (bot) in branch '3.9': bpo-42958: Improve description of shallow= in filecmp.cmp docs (GH-27166) (GH-27608) https://github.com/python/cpython/commit/7dad0337518a0d599caf8f803a5bf45db67cbe9

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

miss-islington added the comment: New changeset c2593b4d06712cefcdeae93b32f88faa4772bc3a by Miss Islington (bot) in branch '3.10': bpo-42958: Improve description of shallow= in filecmp.cmp docs (GH-27166) https://github.com/python/cpython/commit/c2593b4d06712cefcdeae93b32f88faa4772bc3a

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Change by miss-islington : -- pull_requests: +26103 pull_request: https://github.com/python/cpython/pull/27608 ___ Python tracker ___ __

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Łukasz Langa added the comment: New changeset a8dc4893d2b28827e82447326ea47759c161a722 by andrei kulakov in branch 'main': bpo-42958: Improve description of shallow= in filecmp.cmp docs (GH-27166) https://github.com/python/cpython/commit/a8dc4893d2b28827e82447326ea47759c161a722 -- me

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Andrei Kulakov added the comment: Alexander: sorry, I didn't notice your PR because I was first working on a different issue, and then found this as a duplicate, and only noticed there's already an open PR here. If you prefer, we can close my PR and work on updating yours. -- _

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Andrei Kulakov added the comment: I've put up the doc update PR here: https://github.com/python/cpython/pull/27166 I've also reviewed a few dozen SO questions about filecmp.cmp and shallow arg, many of them find the docs confusing or lacking, so I thought updating docs is definitely very use

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Change by Andrei Kulakov : -- pull_requests: +25702 pull_request: https://github.com/python/cpython/pull/27166 ___ Python tracker ___ __

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Christof Hanke added the comment: Andrei, cmp is the deep-compare part of filecmp. I thought we were taking about the shallow one. Thus, - shallow like rsync "quick": size + mtime. - deep like cmp -- ___ Python tracker

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Andrei Kulakov added the comment: But rsync is a quite more specific tool. For example, unix cmp command does not guess based on any part of `stat` sig. That's a much closer command in scope to 'filecmp'. -- ___ Python tracker

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Christof Hanke added the comment: Hi Andrei, I would follow rsync. >From the man page: """ [...] -c, --checksum This changes the way rsync checks if the files have been changed and are in need of a transfer. Without this option, rsync uses a "quick check"

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Andrei Kulakov added the comment: Also see this 16 years old issue: https://bugs.python.org/issue1234674 -- ___ Python tracker ___

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Andrei Kulakov added the comment: Christof and Alexander, as you both said your preference is to have some way of enforcing "only shallow" compare, I want to clarify -- it seems if you do that, you will get the answer of True if the files are most likely the same (sig is equal), but if the s

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Christof Hanke added the comment: Hi, this is also discussed in https://bugs.python.org/issue41354. Ciao, Christof -- nosy: +chanke ___ Python tracker ___

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Josh Rosenberg added the comment: This is a problem with the docstring. The actual docs for it are a bit more clear, https://docs.python.org/3/library/filecmp.html#filecmp.cmp : "If shallow is true, files with identical os.stat() signatures are taken to be equal. Otherwise, the contents of t

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

Change by Alexander Vandenbulcke : -- keywords: +patch pull_requests: +23067 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24246 ___ Python tracker _

[issue42958] filecmp.cmp(shallow=True) isn't actually shallow when only mtime differs

New submission from Alexander Vandenbulcke : Consider the case where 2 files are shallow compared where only the mtime differs (i.e. the mode and size is identical). With filecmp.cmp(f1, f2, shallow=True) a deep compare would be performed behind the scenes since the guard clauses fell through