[issue42847] Normalise file encodings in Lib/sqlite3/test/

Berker Peksag added the comment: iso-8859-1 is still commonly used in some parts of Nordic countries, but I don't see a reason not to change it here :) Thank you, Erlend! -- components: +Tests -Library (Lib) type: -> enhancement ___ Python tracker

[issue42847] Normalise file encodings in Lib/sqlite3/test/

Change by Erlend Egeberg Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue42847] Normalise file encodings in Lib/sqlite3/test/

Berker Peksag added the comment: New changeset deab1e54ff1695cdbe87f8db3d2c382d8e78330f by Erlend Egeberg Aasland in branch 'master': bpo-42847: Normalise Lib/sqlite3/test/* file encodings (GH-24147) https://github.com/python/cpython/commit/deab1e54ff1695cdbe87f8db3d2c382d8e78330f -

[issue42847] Normalise file encodings in Lib/sqlite3/test/

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +22975 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24147 ___ Python tracker _

[issue42847] Normalise file encodings in Lib/sqlite3/test/

Erlend Egeberg Aasland added the comment: Indeed it is. I'll create a PR as soon as GH-20538 is merged. -- ___ Python tracker ___ _

[issue42847] Normalise file encodings in Lib/sqlite3/test/

Guido van Rossum added the comment: SGTM, the use of ISO-8859 is surely a legacy issue. -- nosy: +gvanrossum ___ Python tracker ___ ___

[issue42847] Normalise file encodings in Lib/sqlite3/test/

New submission from Erlend Egeberg Aasland : GitHub does not play well with other file encodings than UTF-8. For example, when the "suggestion" in https://github.com/python/cpython/pull/20538#discussion_r552926126 was applied, GitHub silently converted Lib/sqlite3/test/types.py from ISO-8859