[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

Christian Heimes added the comment: Thank you for your thorough testing. It's useful to know that the option does not speed up PGO builds of Python. -- ___ Python tracker ___

[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

Ma Lin added the comment: Last benchmark was wrong, \Ob3 option was not enabled. Apply `pgo_ob3.diff`, it slows, so I close this issue. +-++--+ | Benchmark | py39_pgo_a | py39_pgo_b | +

[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

Ma Lin added the comment: In PGO build, the improvement is not much. (3.9 branch, with PGO, build.bat -p X64 --pgo) +-+--+--+ | Benchmark | baseline-pgo | ob3-pgo | +=+==

[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

Ma Lin added the comment: > Could you please try again with PGO? Please wait. BTW, this option was advised in another project. In that project, even enable `\Ob3`, it still slower than GCC 9 build. If you are interested, see: https://github.com/facebook/zstd/issues/2314 -- _

[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

Christian Heimes added the comment: Could you please try again with PGO? All our official builds use PGO. -- nosy: +christian.heimes ___ Python tracker ___ ___

[issue42366] Use MSVC2019 and /Ob3 option to compile Windows builds

New submission from Ma Lin : MSVC2019 has a new option `/Ob3`, it specifies more aggressive inlining than /Ob2: https://docs.microsoft.com/en-us/cpp/build/reference/ob-inline-function-expansion?view=msvc-160 If use this option in MSVC2017, it will emit a warning: cl : Command line warning D900