[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks, E. Paine! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.7 ___ Python tracker __

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread miss-islington
miss-islington added the comment: New changeset 532ebba6c8697d214a0d94514ad0b2464a59cb7c by Miss Islington (bot) in branch '3.10': bpo-42278: Use tempfile.TemporaryDirectory rather than tempfile.mktemp in pydoc (GH-23200) https://github.com/python/cpython/commit/532ebba6c8697d214a0d94514ad0b

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 193443bb708cba3a72e99e61dd6615a94f22f9e1 by Miss Islington (bot) in branch '3.8': bpo-42278: Use tempfile.TemporaryDirectory rather than tempfile.mktemp in pydoc (GH-23200) (GH-28026) https://github.com/python/cpython/commit/193443bb708cba3a72e99e

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 45409518c1cec5ee91d49f69a2f8eb4196d242f0 by Miss Islington (bot) in branch '3.9': bpo-42278: Use tempfile.TemporaryDirectory rather than tempfile.mktemp in pydoc (GH-23200) (GH-28025) https://github.com/python/cpython/commit/45409518c1cec5ee91d49f

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 10.0 -> 11.0 pull_requests: +26470 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/28024 ___ Python tracker ___

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset c9227df5a9d8e958a2324cf0deba8524d1ded26a by E-Paine in branch 'main': bpo-42278: Use tempfile.TemporaryDirectory rather than tempfile.mktemp in pydoc (GH-23200) https://github.com/python/cpython/commit/c9227df5a9d8e958a2324cf0deba8524d1ded26a --

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread miss-islington
Change by miss-islington : -- pull_requests: +26471 pull_request: https://github.com/python/cpython/pull/28025 ___ Python tracker ___ __

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-08-29 Thread miss-islington
Change by miss-islington : -- pull_requests: +26472 pull_request: https://github.com/python/cpython/pull/28026 ___ Python tracker ___ __

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-02-03 Thread E. Paine
Change by E. Paine : -- components: -Distutils resolution: out of date -> status: closed -> open ___ Python tracker ___ ___ Python

[issue42278] Remove usage of tempfile.mktemp in stdlib

2021-02-03 Thread Steve Dower
Steve Dower added the comment: Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If y

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-16 Thread Steve Dower
Steve Dower added the comment: Just left a blocking review on the PR - I don't want to rely on the shell being able to use an already open file. There's at least one other issue about making NamedTemporaryFile work for this case. Once that is done, this can be made to work. --

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-08 Thread E. Paine
Change by E. Paine : -- keywords: +patch pull_requests: +22100 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23200 ___ Python tracker ___ ___

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-08 Thread E. Paine
E. Paine added the comment: > Most of them are in tests. There is no security issue there TBH, I don't know enough about the exploit to comment, but it seems that the tempfile tests take this seriously (Lib/test/test_tempfile.py:782 "For safety, all use of mktemp must occur in a private direc

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-08 Thread Steve Dower
Steve Dower added the comment: Yeah, once tests are excluded and the (deprecated or nearly deprecated) distutils and msilib are dropped, the problems are pydoc (which looks non-exploitable) and anywhere we need to generate a named pipe. Both cases where named pipes are being created are as s

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Most of them are in tests. There is no security issue there, also the code may be clearer and more reliable if use helper function test.support.temp_dir(). And most of the rest are in Windows specific code. Some Windows code may not work if you hold open f

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-07 Thread E. Paine
Change by E. Paine : -- components: +Distutils nosy: +dstufft, eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-06 Thread Eric V. Smith
Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue42278] Remove usage of tempfile.mktemp in stdlib

2020-11-06 Thread E. Paine
New submission from E. Paine : Currently, there are many uses of `tempfile.mktemp` in the stdlib. I couldn't find an issue where this has already been discussed, but I think the usage of mktemp in the stdlib should be completely reviewed. I grepped the Lib and a slightly filtered version is t