[issue41142] msilib.CAB doesnot support non-ASCII files

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41142] msilib.CAB doesnot support non-ASCII files

Serhiy Storchaka added the comment: New changeset ba67d7386edf20bcc0f878a518de0894cb574e9f by Serhiy Storchaka in branch 'master': bpo-41142: Add support of non-ASCII paths for CAB files. (GH-21195) https://github.com/python/cpython/commit/ba67d7386edf20bcc0f878a518de0894cb574e9f --

[issue41142] msilib.CAB doesnot support non-ASCII files

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +20349 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21195 ___ Python tracker ___

[issue41142] msilib.CAB doesnot support non-ASCII files

New submission from Serhiy Storchaka : There are several problems with _msi.FCICreate() used to create the CAB file. It encodes the CAB names and added file names to UTF-8 and then use them as encoded with the local encoding. So you cannot create a CAB file in a directory with non-ASCII name