[issue41132] F-String parser uses raw allocator

2020-06-27 Thread miss-islington
miss-islington added the comment: New changeset 749d3bc04177ff9e2ddfd58d919b84cb4f6cf894 by Lysandros Nikolaou in branch '3.8': [3.8] bpo-41132: Use pymalloc allocator in the f-string parser (GH-21173) (GH-21184) https://github.com/python/cpython/commit/749d3bc04177ff9e2ddfd58d919b84cb4f6cf8

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread miss-islington
miss-islington added the comment: New changeset 5193d0a665eb0944faae9fb20e2062cea0dc02e7 by Lysandros Nikolaou in branch '3.9': [3.9] bpo-41132: Use pymalloc allocator in the f-string parser (GH-21173) (GH-21183) https://github.com/python/cpython/commit/5193d0a665eb0944faae9fb20e2062cea0dc02

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +20340 pull_request: https://github.com/python/cpython/pull/21184 ___ Python tracker ___ __

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +20339 pull_request: https://github.com/python/cpython/pull/21183 ___ Python tracker ___ __

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 6dcbc2422de9e2a7ff89a4689572d84001e230b2 by Lysandros Nikolaou in branch 'master': bpo-41132: Use pymalloc allocator in the f-string parser (GH-21173) https://github.com/python/cpython/commit/6dcbc2422de9e2a7ff89a4689572d84001e230b2 ---

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Eric V. Smith
Eric V. Smith added the comment: I think backporting to 3.8 would be okay. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Ok, I've opened a PR. Should be backport this to previous versions as well? -- ___ Python tracker ___ ___

[issue41132] F-String parser uses raw allocator

2020-06-27 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +20331 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21173 ___ Python tracker _

[issue41132] F-String parser uses raw allocator

2020-06-26 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Why would pymalloc be preferred? For such small and temporary string is normally faster because it will likely have pools of that size readily available and it will also benefit further allocation of the same pool size. --

[issue41132] F-String parser uses raw allocator

2020-06-26 Thread Eric V. Smith
Eric V. Smith added the comment: I don't think I put any thought into it. It was probably just in an example I was copying from. I'm not familiar with the difference between those allocators. Why would pymalloc be preferred? -- ___ Python tracker

[issue41132] F-String parser uses raw allocator

2020-06-26 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : The f-string parser uses the raw allocator in various places. We had a very very brief discussion about this with Pablo and he suggested to change the new parser and the hand-written f-string parser to use the pymalloc allocator. Eric, is there a speci