[issue41070] Simplify pyshellext.dll build

Nikita Nemkin added the comment: Thanks for reviewing my patches so quickly, Steve. There's one last Windows-specific patch left (https://bugs.python.org/issue41038). Single-line change. -- ___ Python tracker

[issue41070] Simplify pyshellext.dll build

Steve Dower added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue41070] Simplify pyshellext.dll build

Steve Dower added the comment: New changeset bbf36e8903f8e86dcad8131c818e122537c30f9e by Nikita Nemkin in branch 'master': bpo-41070: Simplify pyshellext.dll build (GH-21037) https://github.com/python/cpython/commit/bbf36e8903f8e86dcad8131c818e122537c30f9e -- __

[issue41070] Simplify pyshellext.dll build

Steve Dower added the comment: Looks good, but I'll want to manually test this, as it's not covered by automated tests. (If you happen to know how to test drag-drop of multiple files and non-MBCS filenames in Explorer, would love to have some tests, but given the low churn on this part I sus

[issue41070] Simplify pyshellext.dll build

Change by Nikita Nemkin : -- keywords: +patch pull_requests: +20209 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21037 ___ Python tracker ___ __

[issue41070] Simplify pyshellext.dll build

New submission from Nikita Nemkin : pyshellext uses MIDL to generate a header, whose only purpose is to define a class GUID. MIDL generation step can be replaced with a simple #define. This doesn't really matter for VS, but other build systems (CMake, probably Meson too) will benefit. pyshel