[issue41054] Simplify resource compilation on Windows

Steve Dower added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue41054] Simplify resource compilation on Windows

miss-islington added the comment: New changeset cebd43fbfd25a80404728f73edc301f9558d9410 by Miss Islington (bot) in branch '3.9': bpo-41054: Simplify resource compilation on Windows (GH-21004) https://github.com/python/cpython/commit/cebd43fbfd25a80404728f73edc301f9558d9410 --

[issue41054] Simplify resource compilation on Windows

Steve Dower added the comment: New changeset 4efc3360c9a83d5891f27ed67b4f0ab7275d2ab4 by Nikita Nemkin in branch 'master': bpo-41054: Simplify resource compilation on Windows (GH-21004) https://github.com/python/cpython/commit/4efc3360c9a83d5891f27ed67b4f0ab7275d2ab4 -- ___

[issue41054] Simplify resource compilation on Windows

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +20257 pull_request: https://github.com/python/cpython/pull/21091 ___ Python tracker _

[issue41054] Simplify resource compilation on Windows

Steve Dower added the comment: Looks good. Let's rename PYTHON_DLL_NAME to ORIGINAL_FILENAME, since it took me 10 minutes to figure out that that's how it's used... We'll backport this one to 3.9 before RC. No NEWS file required. -- versions: +Python 3.9

[issue41054] Simplify resource compilation on Windows

Change by Nikita Nemkin : -- keywords: +patch pull_requests: +20178 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21004 ___ Python tracker ___ __

[issue41054] Simplify resource compilation on Windows

New submission from Nikita Nemkin : Every Windows project has a custom target (included from pyproject.props) that generates a header with definitions for resource files. Those definitions (PYTHON_DLL_NAME and FIELD3) can be passed directly to resource compiler. Another definition (MS_DLL_ID