[issue41039] Simplify python3.dll build

Steve Dower added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue41039] Simplify python3.dll build

Steve Dower added the comment: New changeset 2c6e4e91c5a4d3f25908108f4ed32aba936df70c by Nikita Nemkin in branch 'master': bpo-41039: Simplify python3.dll build (GH-20989) https://github.com/python/cpython/commit/2c6e4e91c5a4d3f25908108f4ed32aba936df70c -- _

[issue41039] Simplify python3.dll build

Nikita Nemkin added the comment: Please take your time. FWIW, I tested this patch by 1) comparing dumpbin /exports output; 2) comparing bunaries themselves (.dll and .lib) and 3) linking xxlmited module. It helps that 7-zip can open .dll and .lib files files as if they were archives. --

[issue41039] Simplify python3.dll build

Steve Dower added the comment: Thanks for the change. It looks good, though I would like to have a NEWS entry for this so that people can find that we made a deliberate change to this DLL. I'd also like to do some manual testing to make sure that we aren't going to break any obscure uses. Th

[issue41039] Simplify python3.dll build

Change by Cheryl Sabella : -- nosy: +eryksun ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue41039] Simplify python3.dll build

Change by Nikita Nemkin : -- keywords: +patch pull_requests: +20163 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20989 ___ Python tracker ___ __

[issue41039] Simplify python3.dll build

New submission from Nikita Nemkin : python3.dll build process can be simplified if we use linker comment #pragma instead of .def files. Custom build targets become unnecessary and hardcoded Python DLL name can be replaced with a macro. Also, python3.dll doesn't need DllMain and can be built w