[issue41025] C implementation of ZoneInfo cannot be subclassed

Change by Łukasz Langa : -- priority: release blocker -> critical stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ __

[issue41025] C implementation of ZoneInfo cannot be subclassed

Łukasz Langa added the comment: I will be cutting RC2 from the head of 3.9. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: This is fixed in the 3.9 and master branches, it needs to be cherry-picked into the 3.9.0 release (at Łukasz's discretion, of course). Łukasz: If you cherry-pick GH-20965/GH-21876 into the 3.9.0 release, please also cherry-pick GH-21907/GH-21912, since that fix

[issue41025] C implementation of ZoneInfo cannot be subclassed

STINNER Victor added the comment: Paul: What is the status of this issue? Is it already fixed? It is the release blocker priority. -- ___ Python tracker ___ _

[issue41025] C implementation of ZoneInfo cannot be subclassed

STINNER Victor added the comment: > test_zoneinfo leaked [84, 84, 84] references, sum=252 Reported as bpo-41568 and fixed there. -- ___ Python tracker ___ ___

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: There are two refleaks here. One is a reference leaking to the weak cache in `__init_subclass__` (one leak every time a subclass is created), and the other is that when `subclass.clear_cache()` is called, it sets `ZONEINFO_STRONG_CACHE = NULL`, thus causing a

[issue41025] C implementation of ZoneInfo cannot be subclassed

STINNER Victor added the comment: > New changeset 87d8287865e5c9f137f6b5cf8c34c2c509eb5e9d by Paul Ganssle in > branch 'master': > bpo-41025: Fix subclassing for zoneinfo.ZoneInfo (GH-20965) This change introduced a reference leak. 3.9 and master branch are affected. $ make && ./python -m te

[issue41025] C implementation of ZoneInfo cannot be subclassed

Change by Paul Ganssle : -- stage: patch review -> backport needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: Marking as release blocker to put it on the checklist. Feel free to demote it if you decide it should be deferred to 3.9.1. -- priority: high -> release blocker resolution: -> fixed ___ Python tracker

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: Łukasz: Would it be possible to backport / cherry-pick the changes from PR GH-21876 (https://github.com/python/cpython/pull/21876) into the 3.9.0 branch? I think this is a fairly severe issue considering that pendulum is planning to use a zoneinfo subclass. It

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: New changeset 33d3c64095bcdf9066a3441f6dda5d2e2f4118a8 by Miss Islington (bot) in branch '3.9': bpo-41025: Fix subclassing for zoneinfo.ZoneInfo (GH-20965) (GH-21876) https://github.com/python/cpython/commit/33d3c64095bcdf9066a3441f6dda5d2e2f4118a8 --

[issue41025] C implementation of ZoneInfo cannot be subclassed

Paul Ganssle added the comment: New changeset 87d8287865e5c9f137f6b5cf8c34c2c509eb5e9d by Paul Ganssle in branch 'master': bpo-41025: Fix subclassing for zoneinfo.ZoneInfo (GH-20965) https://github.com/python/cpython/commit/87d8287865e5c9f137f6b5cf8c34c2c509eb5e9d -- __

[issue41025] C implementation of ZoneInfo cannot be subclassed

Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +21001 pull_request: https://github.com/python/cpython/pull/21876 ___ Python tracker _

[issue41025] C implementation of ZoneInfo cannot be subclassed

Change by Paul Ganssle : -- keywords: +patch pull_requests: +20143 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/20965 ___ Python tracker

[issue41025] C implementation of ZoneInfo cannot be subclassed

New submission from Paul Ganssle : In the C implementation of zoneinfo.ZoneInfo, __init_subclass__ is not declared as a classmethod, which prevents it from being subclassed. This was not noticed because the tests for ZoneInfo subclasses in C are actually testing zoneinfo.ZoneInfo, not a subcla