[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 ___ Python tracker ___

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread hai shi
hai shi added the comment: > Coverage jobs are still run with my changes. > https://codecov.io/gh/python/cpython is still updated. Copy that, thanks. -- ___ Python tracker __

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: > coverage jobs can tell us how many features need add unit tests. Coverage jobs are still run with my changes. https://codecov.io/gh/python/cpython is still updated. My change only stops running coverage jobs on pull requests. -- _

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread hai shi
hai shi added the comment: > Attached PR skips these jobs on pull requests. I am not familiar with travis ci. coverage jobs can tell us how many features need add unit tests. Can we use other CI services to do this job? MAYBE in checks gate or something other services like buildbot.python.org

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread miss-islington
miss-islington added the comment: New changeset 071bed842eeff9673bc5c4f64e3916a151132d2a by Miss Islington (bot) in branch '3.8': bpo-40993: Don't run Travis CI coverage on PRs (GH-20916) https://github.com/python/cpython/commit/071bed842eeff9673bc5c4f64e3916a151132d2a -- _

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread miss-islington
miss-islington added the comment: New changeset 3cf809475a93228a3cb310b4d10d38f3b9d44c1f by Miss Islington (bot) in branch '3.9': bpo-40993: Don't run Travis CI coverage on PRs (GH-20916) https://github.com/python/cpython/commit/3cf809475a93228a3cb310b4d10d38f3b9d44c1f -- _

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread hai shi
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +20097 pull_request: https://github.com/python/cpython/pull/20918 ___ Python tracker ___ __

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +20096 pull_request: https://github.com/python/cpython/pull/20917 ___ Python tracker _

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset fc710ee266e9461fdba9933ec6004318db588820 by Victor Stinner in branch 'master': bpo-40993: Don't run Travis CI coverage on PRs (GH-20916) https://github.com/python/cpython/commit/fc710ee266e9461fdba9933ec6004318db588820 -- message_count

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: Documentation about skipping jobs on pull requests: https://docs.travis-ci.com/user/pull-requests/#how-pull-requests-are-built I don't think that the following method works for the issue: "To only build on push events not on pull requests, disable Build on Pu

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-40237: "Test code coverage (C) job of Travis CI fails on test_distutils which creates _configtest.gcno file". -- ___ Python tracker ___

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: See also "Travis CI doesn't report its status or doesn't run on Python pull requests": https://github.com/python/core-workflow/issues/371 -- ___ Python tracker

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +20095 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20916 ___ Python tracker ___ _

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
STINNER Victor added the comment: Concrete issue: on my PR 20915, Travis CI mandatory jobs completed successfully but I wasn't able to merge the PR since GitHub says "travis-ci/pr Pending — The Travis CI build is in progress". I cancelled the last running coverage job... but I was still unabl

[issue40993] Don't run Python and C coverage jobs of Travis CI on pull requests

2020-06-16 Thread STINNER Victor
New submission from STINNER Victor : Currently, Travis CI runs C coverage and Python coverage jobs on all pull requests. This is a waste of resources: we should only run these jobs on branches like master. Attached PR skips these jobs on pull requests. Not only it's a waste of resources, but