[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

R. David Murray added the comment: Yes, this is a very good point. (And your passing test is worthwhile, you are correct.) People are expected to be able to write handlers, so clearly the timeout API needs to be documented, if for no other reason than to keep a handler writer from stomping

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Indra Talip added the comment: Ah sorry you are right the tests didn't test the specific case of someone overriding the OpenerDirector. The intent was to demonstrate that adding a default timeout to Request didn't break things. I think you are right about how much of an issue this is. I agree

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

R. David Murray added the comment: Thanks, but the new test doesn't fail. With your test patch, test_default_values fails, but that is explicitly checking for the 'timeout' attribute, which isn't actually part of the public API. The new test passes even without the fix. Reading the original

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Indra Talip added the comment: patch adds regressions tests to ensure timeout value from OpenerDirector is honoured and a failing test for a default value for Request.timeout that passes when the patch that initialises Request.timeout is applied. -- Added file: http://bugs.python.org/f

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

R. David Murray added the comment: Now we need a test :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Changes by Indra Talip : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Changes by R. David Murray : -- stage: test needed -> patch review status: languishing -> open ___ Python tracker ___ ___ Python-bugs-l

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Indra Talip added the comment: patch initializes the 'timeout' attribute on urllib2.Request.__init__() -- keywords: +patch nosy: +italip versions: +Python 3.4 -Python 2.6 Added file: http://bugs.python.org/file30873/issue-4079-1.patch ___ Python track

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Facundo Batista added the comment: I'm ok with the proposed changes from Sidnei (yes, a patch is needed). -- ___ Python tracker ___ __

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

R. David Murray added the comment: Senthil, Facundo, is there a reason this bug shouldn't be fixed, or are we just waiting for someone to come up with a patch? I'm assuming the latter and setting it to languishing, but maybe this will wake somebody up who is interested in fixing it. ---

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Changes by John J Lee <[EMAIL PROTECTED]>: -- nosy: +facundobatista ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mail

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

John J Lee <[EMAIL PROTECTED]> added the comment: This bug was known before the release -- unfortunately the original author of the patch didn't fix them in time. This and some other unresolved issues listed are listed on #2451. "Somebody" should raise bugs about the rest of them too, and fix t

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

Senthil <[EMAIL PROTECTED]> added the comment: http://bugs.python.org/issue4079 -- nosy: +orsenthil ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

New submission from Sidnei da Silva <[EMAIL PROTECTED]>: 'urllib2' has introduced a configurable 'timeout' setting by assigning to the 'timeout' attribute of the urllib2.Request object. However the implementation is flawed: - the 'timeout' attribute is set in OpenerDirector.open() and nowhere el